#122 #123 Centralize configuration in the server #90
Conversation
- Merge ServerConfiguration and DiagramConfiguration - Centralize model update protocol in Model Submission Handler fixes eclipse-glsp/glsp/issues/122 fixes eclipse-glsp/glsp/issues/123 Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
|
Note: I also have the corresponding client-side changes (Which simply removes the needsClientLayout parameter from the client); I'll create a separate PR if these changes are fine. The client-side changes aren't actually required (strictly speaking), as the extra parameter would simply be ignored by the server. |
| default ServerLayoutKind getLayoutKind() { return ServerLayoutKind.NONE; } | ||
|
|
||
| default boolean needsClientLayout() { | ||
| return false; |
There was a problem hiding this comment.
Default should be true. Unless label sizes are computed explicitly on the server side (which isn't the case in any of our current usecases) we always need client layouting
| * The {@link GModelState} | ||
| * @return | ||
| * A list of Actions to be processed in order to submit the model | ||
| */ | ||
| public List<Action> doSubmitModel(final boolean update, final GModelState modelState) { |
There was a problem hiding this comment.
Maybe just call it submitModel?
|
This looks very useful to me! Can we get this merged soon? |
|
Closed in favor of #95 |
This addresses both eclipse-glsp/glsp/issues/122 and eclipse-glsp/glsp/issues/123, as the changes to needsClientLayout affects the way the ModelSubmissionHandler is implemented.