-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLSP-1240: Ensure compatibility with >= Theia 1.44 #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I used this for #197 and it worked fine.
Note: I didn't do extensive testing of the entire GLSP stack, so another review is still welcome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM too 👍
GLSP-1240: Ensure compatibility with >= Theia 1.45
In general the change seems to work great and interrupt/reconnect works for the most cases. I tested this by updating the server to send a This becomes more of an issue if the frontend disconnects while a Theia has supports buffering of messages (see https://github.com/eclipse-theia/theia/blob/3034c0a0b4dd1082589ee5ec78a066a8532705fa/packages/core/src/node/messaging/websocket-frontend-connection-service.ts#L129) while the socket is disconnected so I think some special handling is required on our side to properly forward those messages to the glsp client. |
Fix API breaks introduced with Theia 1.44.
Update
Theia Version Compatibility
section in README.md.Note that mentioned
2.1.0-theia1.44.0
version is not released yet.I will do so once this change is approved.