GLSP-1354: Improve viewport restore on diagram open #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move viewport restoration logic from the diagram manager to the `onAfterAttach` method of the diagram widget. This ensures that the viewport restoration allways works independently of how the diagram has been created (WidgetOpenHandler vs. direct creation). Fixes eclipse-glsp/glsp#1354 Also - Move `RequestModelOptions` generation into a submethod for easier extendibility - Register the mouse enter/mouse leave listeners via the `addEventListener` utility method which already has built-in dispose on detach behavior
martin-fleck-at
approved these changes
Jul 1, 2024
| @@ -139,8 +141,8 @@ export class GLSPDiagramWidget extends BaseWidget implements SaveableSource, Sta | |||
| this.addClipboardListener(this.node, 'paste', e => this.handlePaste(e)); | |||
| this.addClipboardListener(this.node, 'cut', e => this.handleCut(e)); | |||
| } | |||
| this.node.addEventListener('mouseenter', e => this.handleMouseEnter(e)); | |||
| this.node.addEventListener('mouseleave', e => this.handleMouseLeave(e)); | |||
| this.addEventListener(this.node, 'mouseenter', e => this.handleMouseEnter(e)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Move viewport restoration logic from the diagram manager to the
onAfterAttachmethod of the diagram widget. This ensures that the viewport restoration allways works independently of how the diagram has been created (WidgetOpenHandler vs. direct creation). Fixes eclipse-glsp/glsp#1354Also
RequestModelOptionsgeneration into a submethod for easier extendibilityaddEventListenerutility method which already has built-in dispose on detach behaviorHow to test
Follow-ups
Changelog