Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify about widget active/not-active state #64

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Notify about widget active/not-active state #64

merged 2 commits into from
Feb 8, 2021

Conversation

planger
Copy link
Member

@planger planger commented Feb 5, 2021

Also consider the active state in the styling to avoid jarring
colors for selection while inactive.

Fixes eclipse-glsp/glsp#184

@planger
Notify about widget active/not-active state
6c928a2 
Also consider the active state in the styling to avoid jarring
colors for selection while inactive.

Fixes eclipse-glsp/glsp#184
martin-fleck-at
martin-fleck-at approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good and works very well! Great work and finally we can put one annoying bug to rest ;-) I also really like the active/inactive style changes, it's often those little things that can make a difference to a user, thank you!

@martin-fleck-at
Update yarn.lock
a87f8cc 
Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
@martin-fleck-at martin-fleck-at merged commit f6b0375 into master Feb 8, 2021
@martin-fleck-at martin-fleck-at deleted the planger/issues/184 branch February 8, 2021 11:38
@planger planger mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-fleck-at martin-fleck-at martin-fleck-at approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hover remains visible when widget becomes inactive
3 participants
@planger @martin-fleck-at @tortmayr