Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve VSCode styling #22

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Improve VSCode styling #22

merged 2 commits into from
Feb 2, 2022

Conversation

planger
Copy link
Member

@planger planger commented Jan 24, 2022

  • Update GLSP dependency
  • Improve styling for VSCode
  • Change example file to the new format

eclipse-glsp/glsp#492

@planger
Improve VSCode styling
4ab0946 
  * Update GLSP dependency
  * Improve styling for VSCode
  * Change example file to the new format

eclipse-glsp/glsp#492
ndoschek
ndoschek requested changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update Philip, the diagram in VSCode looks great! 🎉

I noticed that the resizing of nodes does not work (as well as it doesn't on current master).
The feature table at https://github.com/eclipse-glsp/glsp#features however states it should work. Therefore, due to the unsupported resizing, the category nodes are not properly supported in the VSCode diagram. Could you please have a look at that?

It would be great if you could also update the diagram GIF (/documentation/vscode-diagram.gif) to match the new styling. Thanks!

@planger
Copy link
Member Author

planger commented Feb 1, 2022

Thanks for the review!

I noticed that the resizing of nodes does not work (as well as it doesn't on current master). The feature table at https://github.com/eclipse-glsp/glsp#features however states it should work. Therefore, due to the unsupported resizing, the category nodes are not properly supported in the VSCode diagram. Could you please have a look at that?

As this isn't related to this change, I think it'd be better to create a separate GH issue and PR for that.

It would be great if you could also update the diagram GIF (/documentation/vscode-diagram.gif) to match the new styling. Thanks!

Yes, good point! I'll update this PR with a new GIF.

@planger
Copy link
Member Author

planger commented Feb 1, 2022

I've created the new issue re resizing of nodes: eclipse-glsp/glsp#516

@planger
Copy link
Member Author

planger commented Feb 1, 2022

The GIFs were always pretty ugly (artifacts in the background), so I switched to MP4 which is nicely supported now too!

@planger planger requested a review from ndoschek February 1, 2022 15:54
ndoschek
ndoschek approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Philip, the video looks great! 🎉

@planger planger merged commit 1c5e79b into master Feb 2, 2022
@planger planger deleted the planger/issues/492 branch February 2, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndoschek ndoschek ndoschek approved these changes

@tortmayr tortmayr Awaiting requested review from tortmayr

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@planger @ndoschek @tortmayr