Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation after refactoring #52

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Update documentation after refactoring #52

merged 3 commits into from
Mar 25, 2022

Conversation

planger
Copy link
Member

@planger planger commented Mar 25, 2022

@planger planger requested a review from tortmayr March 25, 2022 16:51
tortmayr
tortmayr approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to.
Just one general comment: Since it's now part of the snippets I think we should shortly cover source model saving in the Source Model & State section.

tortmayr
tortmayr approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@planger planger merged commit 21052d5 into master Mar 25, 2022
@planger planger deleted the planger/issues/582 branch March 25, 2022 19:55
@planger
Copy link
Member Author

planger commented Mar 25, 2022

Thanks for the fast feedback @tortmayr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@planger @tortmayr