Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reconnect using socket-based GLSP servers #1277

Closed
Tracked by #77
ndoschek opened this issue Feb 27, 2024 · 4 comments
Closed
Tracked by #77

Handle reconnect using socket-based GLSP servers #1277

ndoschek opened this issue Feb 27, 2024 · 4 comments

Comments

@ndoschek
Copy link
Contributor

ndoschek commented Feb 27, 2024

Follow-up of #77

Ensure reconnect handling is properly implemented for the socket-based GLSP servers

  • restoring client connections and client sessions after reconnects/interrupts
@ndoschek ndoschek changed the title Investigate reconnect for socket-based servers (restoring client connections and client sessions) Handle reconnect using socket-based GLSP servers Feb 27, 2024
@planger
Copy link
Member

planger commented Mar 21, 2024

@ndoschek Can this be closed as the PR is merged? Thanks!

@ndoschek
Copy link
Contributor Author

Hi @planger, unfortunately not, as this is the follow-up of the initial issue. We did not provide a fix for socked-based GLSP servers yet, only for the websocket variants.

@tortmayr
Copy link
Contributor

@ndoschek AFAIK socket and direct server in backend now work. This has been fixed with eclipse-glsp/glsp-theia-integration#197

@ndoschek
Copy link
Contributor Author

Ah thanks @tortmayr for refreshing my mind, yes then let's close it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants