Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseGLSPClient should handle reconnect #77

Closed
7 tasks done
eneufeld opened this issue Jun 4, 2020 · 4 comments
Closed
7 tasks done

BaseGLSPClient should handle reconnect #77

eneufeld opened this issue Jun 4, 2020 · 4 comments
Assignees
@CamilleLetavernier @ndoschek
Labels
client

Comments

@eneufeld
Copy link
Contributor

eneufeld commented Jun 4, 2020 •
edited by ndoschek
Loading

The BaseGLSPClient should handle error on the connection better by trying a reconnect similar to how the BaseLSPClient is doing it.

Edit 2023-07-24:

We investigated WebSocket interrupts with the different example integrations.
The websocket server implementations will now handle a reconnect gracefully and respond to a RequestModelAction with the latest modelState (see eclipse-glsp/glsp-server-node#54 and eclipse-glsp/glsp-server#208).

Here is an overview of the examples that can already handle websocket connection interrupts:

What is left to do:
@tortmayr
Copy link
Contributor

Potentially related to #96

@planger planger added the client label Jan 14, 2021
@ndoschek ndoschek self-assigned this Feb 8, 2023
@ndoschek
Copy link
Contributor

ndoschek commented Feb 8, 2023

We have troubles with interrupting connections in a client project that is deployed on a cluster. I will look into this and back contribute the fix once we could verify it works reliably.

@tortmayr tortmayr added this to the 2.0.0 Release (Optional) milestone Feb 8, 2023
@tortmayr tortmayr removed this from the 2.0.0 Release milestone Jun 1, 2023
ndoschek added a commit to eclipse-glsp/glsp-server that referenced this issue Jul 20, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt
aa368c0 
If Websocket connections reconnect after an interrupt, ensure that the last modelState is restored on RequestModelAction if available

Part of eclipse-glsp/glsp#77
ndoschek added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jul 20, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt
4323bf6 
If Websocket connections reconnect after an interrupt, ensure that the last modelState is restored on RequestModelAction if available

Part of eclipse-glsp/glsp#77
ndoschek added a commit to eclipse-glsp/glsp-client that referenced this issue Jul 20, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt
fd70113 
- Introduce GLSPWebSocketProvider to allow websocket connections to reconnect after interrupt
- Make use of ws provider in standalone example

Part of eclipse-glsp/glsp#77
ndoschek added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Jul 20, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt
7f3507f 
- Introduce GLSPWebSocketProvider to allow websocket connections to reconnect after interrupt
- Make use of ws provider in standalone example

Part of eclipse-glsp/glsp#77
This was referenced Jul 20, 2023
Merged
Merged
Merged
Merged
ndoschek added a commit to eclipse-glsp/glsp-server that referenced this issue Jul 24, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt (#208)
8587e82 
* GLSP-77: Allow WebSocket connections to reconnect after interrupt

If Websocket connections reconnect after an interrupt, ensure that the last modelState is restored on RequestModelAction if available

Part of eclipse-glsp/glsp#77
ndoschek added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jul 24, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt (#54)
5fd686c 
* GLSP-77: Allow WebSocket connections to reconnect after interrupt

If Websocket connections reconnect after an interrupt, ensure that the last modelState is restored on RequestModelAction if available

Part of eclipse-glsp/glsp#77
ndoschek added a commit to eclipse-glsp/glsp-client that referenced this issue Jul 24, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt (#269)
3208dc6 
* GLSP-77: Allow WebSocket connections to reconnect after interrupt

- Introduce GLSPWebSocketProvider to allow websocket connections to reconnect after interrupt
- Make use of ws provider in standalone example

Part of eclipse-glsp/glsp#77
ndoschek added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Jul 24, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt
24e3d19 
- Introduce GLSPWebSocketProvider to allow websocket connections to reconnect after interrupt
- Make use of ws provider in standalone example

Part of eclipse-glsp/glsp#77
ndoschek added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Jul 24, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt
417affd 
- Update GLSP dependencies
- Make use of GLSPWebSocketProvider in workflow example

Part of eclipse-glsp/glsp#77
ndoschek added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Jul 25, 2023
@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt (#84)
0ae0e3c 
- Update GLSP dependencies
- Make use of GLSPWebSocketProvider in workflow example

Part of eclipse-glsp/glsp#77
@ndoschek
Copy link
Contributor

For the Theia use cases we should wait for this generic fix in the Theia framework to properly fix the reconnect issue for GLSP:
eclipse-theia/theia#13082

@ndoschek ndoschek mentioned this issue Feb 13, 2024
Merged
This was referenced Feb 27, 2024
Open
Open
Closed
Open
@ndoschek
Copy link
Contributor

As discussed in the last project meeting, we agreed on extracting the remaining reconnect issues (for different use cases) into separate tickets.
See #1275, #1276, #1277, #1278

Closing this now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CamilleLetavernier CamilleLetavernier

@ndoschek ndoschek

Labels
client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@planger @eneufeld @tortmayr @CamilleLetavernier @ndoschek