Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add electron application example to theia-integration #1303

Closed
ndoschek opened this issue Apr 3, 2024 · 1 comment
Closed

Add electron application example to theia-integration #1303

ndoschek opened this issue Apr 3, 2024 · 1 comment
Assignees
@ndoschek
Labels
enhancement New feature or request theia

Comments

@ndoschek
Copy link
Contributor

ndoschek commented Apr 3, 2024 •
edited
Loading

  • Add electron application example to the GLSP theia-integration repository
  • Add the same application versions as for the browser version (i.e. WS GLSP Server, integrated node server etc.)
  • Provide yarn scripts and launch configs for all combinations
  • Ensure rebuild scripts are run prior to starting the application examples (via yarn script or VS Code task for launch configs)
  • Do not build electron application by default, but provide scripts to build from the root directory on demand
  • Provide description in the README

There is already a WIP branch available that contains the first basic electron application example:
https://github.com/eclipse-glsp/glsp-theia-integration/tree/issues/1303
@ndoschek ndoschek added enhancement New feature or request theia labels Apr 3, 2024
@tortmayr
Copy link
Contributor

Resolved with eclipse-glsp/glsp-theia-integration#211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndoschek ndoschek

Labels
enhancement New feature or request theia
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tortmayr @ndoschek