Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further clean up the API #132

Closed
planger opened this issue Oct 22, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#89
Closed

Further clean up the API #132

planger opened this issue Oct 22, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#89
Assignees
@tortmayr
Labels
server-java
Milestone
Eclipse GLSP 0.8....

Comments

@planger
Copy link
Member

planger commented Oct 22, 2020

From eclipse-glsp/glsp-server#81

Great change! I think the capability-based package structure is a big improvement. I only noticed a couple of minor "issues". Maybe we should briefly discuss them here and then great a follow-up ticket for this.

  • The org.eclipse.glsp.server package doesn't follow the capability-based approach it rather serves as a container for miscellaneous that didn't fit anywhere else. Maybe we should move GLSPModule and DefaultGLSPModule into the "di" subpackage and the other classes into the "util" subpackage?
  • org.eclipse.glsp.server.factory package simply groups classes that have the "Factory" affix but are not necessary related to each other. I'd suggest to move the PopupmodelFactory into org.eclipse.glsp.server.features.popup and create a new feature package for model loading where we group the RequestModelAction, the corresponding handler and the ModelFactories
  • Maybe we should also create a feature subpackage for undo/redo.
  • I think it would be a good idea to move all actions that are declared as ClientAction(https://github.com/eclipse-glsp/glsp-server/blob/master/plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/internal/di/MultiBindingDefaults.java#L101) into a dedicated subpackage.
@planger planger added this to the Eclipse GLSP 0.8.0 Release milestone Oct 22, 2020
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Nov 18, 2020
@tortmayr
#132 Further clean up server API
4e66002 
- Move  classes from root package into a matching subpackage
- Create "org.eclipse.glsp.server.features.core.model" package that contains all actions and related classes that are needed for model loading
- Create a dedicated feature subpackage for undo/redo

Resolves eclipse-glsp/glsp/issues/132
@tortmayr tortmayr mentioned this issue Nov 18, 2020
Merged
martin-fleck-at pushed a commit to eclipse-glsp/glsp-server that referenced this issue Nov 19, 2020
@tortmayr
#132 Further clean up server API (#89)
51f95cd 
- Move  classes from root package into a matching subpackage
- Create "org.eclipse.glsp.server.features.core.model" package that contains all actions and related classes that are needed for model loading
- Create a dedicated feature subpackage for undo/redo

Resolves eclipse-glsp/glsp/issues/132
@tortmayr tortmayr self-assigned this Nov 19, 2020
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@tortmayr
eclipse-glsp#132 Further clean up server API (eclipse-glsp#89)
3ce80ce 
- Move  classes from root package into a matching subpackage
- Create "org.eclipse.glsp.server.features.core.model" package that contains all actions and related classes that are needed for model loading
- Create a dedicated feature subpackage for undo/redo

Resolves eclipse-glsp/glsp/issues/132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
server-java
Projects
None yet
Milestone
Eclipse GLSP 0.8.0 Release
Development

Successfully merging a pull request may close this issue.

#132 Further clean up server API eclipse-glsp/glsp-server
2 participants
@planger @tortmayr