Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve customizability of DefaultGLSPServerLauncher #385

Closed
tortmayr opened this issue Sep 8, 2021 · 0 comments · Fixed by eclipse-glsp/glsp-server#128
Closed

Improve customizability of DefaultGLSPServerLauncher #385

tortmayr opened this issue Sep 8, 2021 · 0 comments · Fixed by eclipse-glsp/glsp-server#128
Labels
server-java

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Sep 8, 2021

Some parts of the DefaultGLSPServerLauncher implementation are currently hard to customize. For instance the createClientConnection() method is private and cannot not be overwritten in subclass. Also it's not possible to provide a custom messageWrapper or gsonGonfigurator for the lsp4j launcher.
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Sep 8, 2021
@tortmayr
#385 Improve customizability of DefaultGLSPServerLauncher
c6a6c8a 
- Change visibility of `createClientConnection()` to protected
- Extract creation of gsonConfigurator and messageWrapper into submethods so that  they can be easily overwritten.

Fixes eclipse-glsp/glsp/issues/385
@tortmayr tortmayr mentioned this issue Sep 8, 2021
Merged
martin-fleck-at pushed a commit to eclipse-glsp/glsp-server that referenced this issue Sep 9, 2021
@tortmayr
#385 Improve customizability of DefaultGLSPServerLauncher (#128)
481af2c 
- Change visibility of `createClientConnection()` to protected
- Extract creation of gsonConfigurator and messageWrapper into submethods so that  they can be easily overwritten.

Fixes eclipse-glsp/glsp/issues/385
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@tortmayr
#385 Improve customizability of DefaultGLSPServerLauncher (eclipse-gl…
1cdaf34 
…sp#128)

- Change visibility of `createClientConnection()` to protected
- Extract creation of gsonConfigurator and messageWrapper into submethods so that  they can be easily overwritten.

Fixes eclipse-glsp/glsp/issues/385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
server-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#385 Improve customizability of DefaultGLSPServerLauncher eclipse-glsp/glsp-server
1 participant
@tortmayr