-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit hash in next versions breaks semver resolution #845
Labels
bug
Something isn't working
Comments
tortmayr
added a commit
that referenced
this issue
Oct 13, 2023
Remove breaking commithash from next version publishing Part of #845 s
tortmayr
added a commit
that referenced
this issue
Oct 15, 2023
Remove breaking commithash from next version publishing Part of #845 s
tortmayr
added a commit
that referenced
this issue
Oct 15, 2023
Remove breaking commithash from next version publishing Part of #845
tortmayr
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Nov 5, 2023
tortmayr
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Nov 6, 2023
Part of eclipse-glsp/glsp/issues/845 Co-authored-by: Philip Langer <planger@eclipsesource.com>
tortmayr
added a commit
to eclipse-glsp/glsp-server-node
that referenced
this issue
Nov 6, 2023
tortmayr
added a commit
to eclipse-glsp/glsp-server-node
that referenced
this issue
Nov 6, 2023
This was referenced Nov 6, 2023
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this issue
Dec 21, 2024
Part of eclipse-glsp/glsp/issues/845 Co-authored-by: Philip Langer <planger@eclipsesource.com>
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this issue
Dec 21, 2024
Part of eclipse-glsp/glsp/issues/845 Co-authored-by: Philip Langer <planger@eclipsesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The workaround to add the commit hash into next version qualifiers unfortunatley breaks semver resolution. NPM can no longer correctly derive higher and lower versions.

For instance
^1.1.0-next.903b293.202
should match any version >=^1.1.0-next.x.202
.As we can see in this screenshot this is not the case:
We should handle this in the same way as Theia and simply use the default lerna versioning without the additional commit hash
The text was updated successfully, but these errors were encountered: