Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and cleanup GLSPContribution API #848

Closed
tortmayr opened this issue Jan 5, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-theia-integration#146
Closed

Refactor and cleanup GLSPContribution API #848

tortmayr opened this issue Jan 5, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-theia-integration#146
Assignees
@tortmayr
Labels
breaking enhancement New feature or request theia
Milestone
2.0.0 Release

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Jan 5, 2023

Back in 2019 we based the initial implementation of the GLSP Theia integration on @theia/languages. This still shows in parts of the API.
Some concepts still mentions language clients, session ids etc. In contrast to LSP in GLSP one client manages all sessions (i.e. diagram widgets) of one diagram type.
In addition, we should have a second look on the way we currently bridge the GLSPClient via the backend to the server. Theia's internal rpc communication is no longer based on vscode-jsonrpc so some we currently have to do some weird rpc-message conversion to make it work. Maybe we can find a cleaner approach for this.
@tortmayr tortmayr added enhancement New feature or request theia breaking labels Jan 5, 2023
@tortmayr tortmayr added this to the 2.0.0 Release milestone Jan 5, 2023
@tortmayr tortmayr self-assigned this Jan 18, 2023
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Feb 15, 2023
@tortmayr
Refactor and cleanup GLSPContribution API
927d980 
- Refactor `GLSPCLientProvider` and reuse it in `BaseGLSPTheiaConnector`
- Make GLSPContributions disposable
- Cleanup redundant session concept in `GLSPBackendContribution`
- Cleanup & refactor`GLSPClientContribution` API.
- Cleanup & refactor`GLSPSocketServerContribution` API
- Remove remains from @theia/languages
- Simplify client initialization by using Theia's Deferred concept.

Fixes eclipse-glsp/glsp#848
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Feb 15, 2023
@tortmayr
Refactor and cleanup GLSPContribution API
7bc50ed 
- Refactor `GLSPCLientProvider` and reuse it in `BaseGLSPTheiaConnector`
- Make GLSPContributions disposable
- Cleanup redundant session concept in `GLSPBackendContribution`
- Cleanup & refactor`GLSPClientContribution` API.
- Cleanup & refactor`GLSPSocketServerContribution` API
- Remove remains from @theia/languages
- Simplify client initialization by using Theia's Deferred concept.

Fixes eclipse-glsp/glsp#848
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 4, 2023
@tortmayr
Refactor and cleanup GLSPContribution API
bc1745b 
- Refactor `GLSPCLientProvider` and reuse it in `BaseGLSPTheiaConnector`
- Make GLSPContributions disposable
- Cleanup redundant session concept in `GLSPBackendContribution`
- Cleanup & refactor`GLSPClientContribution` API.
- Cleanup & refactor`GLSPSocketServerContribution` API
- Remove remains from @theia/languages
- Simplify client initialization by using Theia's Deferred concept.

Fixes eclipse-glsp/glsp#848
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 8, 2023
@tortmayr
Refactor and cleanup GLSPContribution API
0564786 
- Refactor `GLSPCLientProvider` and reuse it in `BaseGLSPTheiaConnector`
- Make GLSPContributions disposable
- Cleanup redundant session concept in `GLSPBackendContribution`
- Cleanup & refactor`GLSPClientContribution` API.
- Cleanup & refactor`GLSPSocketServerContribution` API
- Remove remains from @theia/languages
- Simplify client initialization by using Theia's Deferred concept.

Fixes eclipse-glsp/glsp#848
@tortmayr tortmayr mentioned this issue Mar 8, 2023
Merged
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 8, 2023
@tortmayr
Refactor and cleanup GLSPContribution API
ad1346f 
- Refactor `GLSPCLientProvider` and reuse it in `BaseGLSPTheiaConnector`
- Make GLSPContributions disposable
- Cleanup redundant session concept in `GLSPBackendContribution`
- Cleanup & refactor`GLSPClientContribution` API.
- Cleanup & refactor`GLSPSocketServerContribution` API
- Remove remains from @theia/languages
- Simplify client initialization by using Theia's Deferred concept.

Fixes eclipse-glsp/glsp#848
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 11, 2023
@tortmayr
Refactor and cleanup GLSPContribution API
065a06f 
- Refactor `GLSPCLientProvider` and reuse it in `BaseGLSPTheiaConnector`
- Make GLSPContributions disposable
- Cleanup redundant session concept in `GLSPBackendContribution`
- Cleanup & refactor`GLSPClientContribution` API.
- Cleanup & refactor`GLSPSocketServerContribution` API
- Remove remains from @theia/languages
- Simplify client initialization by using Theia's Deferred concept.

Fixes eclipse-glsp/glsp#848
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 15, 2023
@tortmayr
Refactor and cleanup GLSPContribution API
e3f15e7 
- Refactor `GLSPCLientProvider` and reuse it in `BaseGLSPTheiaConnector`
- Make GLSPContributions disposable
- Cleanup redundant session concept in `GLSPBackendContribution`
- Cleanup & refactor`GLSPClientContribution` API.
- Cleanup & refactor`GLSPSocketServerContribution` API
- Remove remains from @theia/languages
- Simplify client initialization by using Theia's Deferred concept.

Fixes eclipse-glsp/glsp#848
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 15, 2023
@tortmayr
Refactor and cleanup GLSPContribution API (#146)
b258494 
- Refactor `GLSPCLientProvider` and reuse it in `BaseGLSPTheiaConnector`
- Make GLSPContributions disposable
- Cleanup redundant session concept in `GLSPBackendContribution`
- Cleanup & refactor`GLSPClientContribution` API.
- Cleanup & refactor`GLSPSocketServerContribution` API
- Remove remains from @theia/languages
- Simplify client initialization by using Theia's Deferred concept.

Fixes eclipse-glsp/glsp#848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
breaking enhancement New feature or request theia
Projects
None yet
Milestone
2.0.0 Release
Development

Successfully merging a pull request may close this issue.

Refactor and cleanup GLSPContribution API eclipse-glsp/glsp-theia-integration
1 participant
@tortmayr