Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup GlspServerLauncher & add CLI parsing #95

Closed
tortmayr opened this issue Aug 12, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#69
Closed

Cleanup GlspServerLauncher & add CLI parsing #95

tortmayr opened this issue Aug 12, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#69
Assignees
@tortmayr

Comments

@tortmayr
Copy link
Contributor

Add CLI parsing similar to how its handled in the emfcloud modelserver (https://github.com/eclipse-emfcloud/emfcloud-modelserver/blob/master/bundles/org.eclipse.emfcloud.modelserver.emf/src/org/eclipse/emfcloud/modelserver/emf/launch/CLIParser.java)

In particular it would be nice to configure the following via CLI arguments:

  • The server port
  • The logger ( in particular console vs file logging and log level)
@tortmayr tortmayr self-assigned this Aug 12, 2020
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Aug 12, 2020
@tortmayr
#95 Cleanup GLSPServerLauncher & add CLI parsing
7a94687 
- Cleanup GLSPServerLauncher (refactor methods & add support to inject additional modules)
- Add a CLIParser helper class and configure default options for configuring
-- Server port
-- consoleLog flag
-- logging directory
-- logLevel
-- help

Fixes eclipse-glsp/glsp/issues/95
@tortmayr tortmayr mentioned this issue Aug 12, 2020
Merged
tortmayr added a commit to eclipse-glsp/glsp-examples that referenced this issue Aug 12, 2020
@tortmayr
#95 Adapt example to conform to GLSPServerLauncher refactoring
2d52f27 
Requires: eclipse-glsp/glsp-server/pull/69
Part of: eclipse-glsp/glsp#95
tortmayr added a commit to eclipse-glsp/glsp-examples that referenced this issue Aug 12, 2020
@tortmayr
#95 Adapt example to conform to GLSPServerLauncher refactoring
3065416 
Add launch configs for Eclipse
Requires: eclipse-glsp/glsp-server/pull/69
Part of: eclipse-glsp/glsp#95
@tortmayr tortmayr mentioned this issue Aug 12, 2020
Merged
martin-fleck-at pushed a commit to eclipse-glsp/glsp-server that referenced this issue Aug 14, 2020
@tortmayr
#95 Cleanup GLSPServerLauncher & add CLI parsing (#69)
07f68d5 
* #95 Cleanup GLSPServerLauncher & add CLI parsing

- Cleanup GLSPServerLauncher (refactor methods & add support to inject additional modules)
- Add a CLIParser helper class and configure default options for configuring
-- Server port
-- consoleLog flag
-- logging directory
-- logLevel
-- help

Fixes eclipse-glsp/glsp/issues/95
martin-fleck-at pushed a commit to eclipse-glsp/glsp-examples that referenced this issue Aug 14, 2020
@tortmayr
#95 Adapt example to conform to GLSPServerLauncher refactoring (#62)
8617786 
* #95 Adapt example to conform to GLSPServerLauncher refactoring

Add launch configs for Eclipse
Requires: eclipse-glsp/glsp-server/pull/69
Part of: eclipse-glsp/glsp#95
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Aug 15, 2020
@tortmayr
Ensure Java 1.8 compatibility in LaunchUtil
7d3ee9c 
Refactor getAppenders() to avoid usage of Enumeration.asIterator() which is not supported by Java 1.8
Follow-up for:  eclipse-glsp/glsp/issues/95
@tortmayr tortmayr mentioned this issue Aug 15, 2020
Merged
martin-fleck-at pushed a commit to eclipse-glsp/glsp-server that referenced this issue Aug 17, 2020
@tortmayr
Ensure Java 1.8 compatibility in LaunchUtil (#71)
dd9fdc5 
Refactor getAppenders() to avoid usage of Enumeration.asIterator() which is not supported by Java 1.8
Follow-up for:  eclipse-glsp/glsp/issues/95
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@tortmayr
eclipse-glsp#95 Cleanup GLSPServerLauncher & add CLI parsing (eclipse…
add144a 
…-glsp#69)

* eclipse-glsp#95 Cleanup GLSPServerLauncher & add CLI parsing

- Cleanup GLSPServerLauncher (refactor methods & add support to inject additional modules)
- Add a CLIParser helper class and configure default options for configuring
-- Server port
-- consoleLog flag
-- logging directory
-- logLevel
-- help

Fixes eclipse-glsp/glsp/issues/95
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@tortmayr
Ensure Java 1.8 compatibility in LaunchUtil (eclipse-glsp#71)
240aa82 
Refactor getAppenders() to avoid usage of Enumeration.asIterator() which is not supported by Java 1.8
Follow-up for:  eclipse-glsp/glsp/issues/95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#95 Cleanup GLSPServerLauncher & add CLI parsing eclipse-glsp/glsp-server
1 participant
@tortmayr