Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI job that runs clang-tidy #889

Closed
r7vme opened this issue Jul 31, 2021 · 0 comments · Fixed by #890
Closed

Add CI job that runs clang-tidy #889

r7vme opened this issue Jul 31, 2021 · 0 comments · Fixed by #890
Assignees
@r7vme
Labels
tooling All iceoryx related tooling (scripts etc.)

Comments

@r7vme
Copy link

r7vme commented Jul 31, 2021 •
edited by dkroenke
Loading

Brief feature description

iceoryx already has a .clang-tidy config, but unfortunately codebase does not pass all checks.

Detailed information

I propose:

  1. Reduce check numbers to the point when codebase passes them
  2. Add CI job that runs clang-tidy
  3. Incrementally add more checks and fix violations
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Jul 31, 2021
iox-eclipse-iceoryx#889 Add clang-tidy workflows
acf8ed5 
Build iceoryx and then run clang-tidy on all cpp files exclude tests.
@r7vme r7vme mentioned this issue Jul 31, 2021
Merged
20 tasks
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Jul 31, 2021
iox-eclipse-iceoryx#889 Add clang-tidy workflows
79dd65b 
Build iceoryx and then run clang-tidy on all cpp files exclude tests.
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Jul 31, 2021
iox-eclipse-iceoryx#889 Add clang-tidy workflows
fe8f4a0 
Build iceoryx and then run clang-tidy on all cpp files exclude tests.
@elBoberido elBoberido added the tooling All iceoryx related tooling (scripts etc.) label Aug 2, 2021
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Aug 2, 2021
iox-eclipse-iceoryx#889 Fix clang-tidy violations
6e9ca3c
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2021
iox-eclipse-iceoryx#889 Fix clang-tidy violations
fda4a12
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2021
iox-eclipse-iceoryx#889 Fix clang-tidy violations
938271d
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2021
iox-eclipse-iceoryx#889 Fix clang-tidy violations
1ac99d6
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2021
iox-eclipse-iceoryx#889 Fix clang-tidy violations for iceoryx_hoofs
a23a166
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang install script for CI
9b311b8
@dkroenke dkroenke mentioned this issue Aug 4, 2021
Merged
20 tasks
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang install script for CI
b413ee6
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang install script for CI
1324cb7
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang install script for CI
d464b20
dkroenke added a commit that referenced this issue Aug 4, 2021
@dkroenke
Merge pull request #897 from ApexAI/iox-#889-fix-clang-experimental-b…
2685910 
…uild

iox-#889 Fix clang install script for CI
@r7vme r7vme mentioned this issue Aug 5, 2021
Merged
20 tasks
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 13, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang-tidy violations for iceoryx_hoofs
1218829
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 18, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang-tidy violations for iceoryx_hoofs
f90b1a3 
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 18, 2021
@dkroenke
iox-eclipse-iceoryx#889 Remove timespec implementation and header
d76bd54 
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 18, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang-tidy violations for iceoryx_hoofs
3a61a5c 
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 18, 2021
@dkroenke
iox-eclipse-iceoryx#889 Remove timespec implementation and header
2fa9843 
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 19, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang-tidy violations for iceoryx_hoofs
fba6ce5
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 19, 2021
@dkroenke
iox-eclipse-iceoryx#889 Remove timespec implementation and header
173647e 
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 20, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang-tidy violations for iceoryx_hoofs
7698784
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 20, 2021
@dkroenke
iox-eclipse-iceoryx#889 Remove timespec implementation and header
a8b96c1 
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 24, 2021
@dkroenke
iox-eclipse-iceoryx#889 Fix clang-tidy violations for iceoryx_hoofs
8b1bced
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 24, 2021
@dkroenke
iox-eclipse-iceoryx#889 Remove timespec implementation and header
2faedf3 
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 24, 2021
@dkroenke
iox-eclipse-iceoryx#889 Rework Tests for TOMLGatewayParser
da80989 
Ignoring the generated test toml config in git
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2022
@dkroenke
iox-eclipse-iceoryx#889 Optimize Clang-Tidy Rules
c0147e4
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2022
@dkroenke
iox-eclipse-iceoryx#889 Rework script for clang-tidy checks
e2b27ef
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2022
@dkroenke
iox-eclipse-iceoryx#889 Add clang-tidy to Pull-Requests in CI
872f38e
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2022
@dkroenke
iox-eclipse-iceoryx#889 Update necessary clang version to 12
707c7a0
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2022
@dkroenke
iox-eclipse-iceoryx#889 Remove clang-tidy in main CI
e217538
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2022
@dkroenke
iox-eclipse-iceoryx#889 Temp: test code-linting on master pipeline
ace1102
dkroenke pushed a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Add clang-tidy workflows
bcf5c45 
Build iceoryx and then run clang-tidy on all cpp files exclude tests.
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Optimize Clang-Tidy Rules
fff6012
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Rework script for clang-tidy checks
c826ba9
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Add Clang-Tidy Check to Pull-Requests in CI
4fd0d81
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Rework and merge scripts
af7a8df
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Move FreeBSD job into nightly build
5ec2bb3
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Add clang-tidy files for different naming styles
1a02a00
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Add clang-tidy files for different naming styles
1b82b02
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Temp: add an uninitialized variable
e511493
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Rework and merge scripts
53c1836
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Move FreeBSD job into nightly build
0a817ee
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Add clang-tidy files for different naming styles
e802436
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Temp: add an uninitialized variable
ce480bc
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
@dkroenke
iox-eclipse-iceoryx#889 Fix compiler warning
0f0abb4
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2022
@dkroenke
iox-eclipse-iceoryx#889 Add clang-tidy files for different naming styles
7893b65
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 7, 2022
@dkroenke
iox-eclipse-iceoryx#889 Allow up to 15 Clang-tidy warnings in PRs
7b52edc
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2022
@dkroenke
iox-eclipse-iceoryx#889 Allow up to 15 Clang-tidy warnings in PRs
9fbcadb
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2022
@dkroenke
iox-eclipse-iceoryx#889 Documentation fixes for hooks
1527982
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2022
@dkroenke
iox-eclipse-iceoryx#889 Add clang-tidy for cxx naming style
4d611ec
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2022
@dkroenke
iox-eclipse-iceoryx#889 Allow up to 15 Clang-tidy warnings in PRs
5a7a2c8
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2022
@dkroenke
iox-eclipse-iceoryx#889 Documentation fixes for hooks
cd0f855
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 9, 2022
@dkroenke
iox-eclipse-iceoryx#889 Documentation fixes for hooks
079a0fe
dkroenke added a commit that referenced this issue Feb 10, 2022
@dkroenke
Merge pull request #890 from ApexAI/iox-#889-add-ci-job-clang-tidy
800957f 
iox-#889 Add clang-tidy workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r7vme r7vme

Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iox-#889 Add clang-tidy workflows ApexAI/iceoryx
2 participants
@r7vme @elBoberido