Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design new StatusPort #982

Closed
3 of 4 tasks
mossmaurice opened this issue Dec 2, 2021 · 3 comments
Closed
3 of 4 tasks

Design new StatusPort #982

mossmaurice opened this issue Dec 2, 2021 · 3 comments
Assignees
Labels
enhancement New feature

Comments

@mossmaurice
Copy link
Contributor

mossmaurice commented Dec 2, 2021

Brief feature description

After this discussion the conclusion was a StatusPort or BroadcastPorts is beneficial for #415 and for the introspection topics, in order to prevent any user to take() the data and not release() which could lead to a out-of-memory error.

Detailed information

References

@mossmaurice mossmaurice added the enhancement New feature label Dec 2, 2021
@mossmaurice mossmaurice self-assigned this Dec 2, 2021
@elfenpiff
Copy link
Contributor

@mossmaurice maybe I missed something but the purpose of the interface port is to forward capro messages for instance to gateway ports.
And the purpose of the StatePort is to deliver some kind of state. How should we be able to replace the InterfacePort with a StatusPort?

And shouldn't it be called StatePort instead of StatusPort?

@mossmaurice
Copy link
Contributor Author

mossmaurice commented Dec 9, 2021

@elfenpiff

maybe I missed something but the purpose of the interface port is to forward capro messages for instance to gateway ports.

That's correct. More broadly speaking InterfacePorts are used to relay discovery information to gateways. After the StatusPorts are available we should consolidate them with both the InterfacePorts and the introspection 2.0 by sending the ServiceRegistry via a StatusPort. For more information also see the design document. Very likely it will be fleshed out from this issue and implemented in a separate one.

And the purpose of the StatePort is to deliver some kind of state. How should we be able to replace the InterfacePort with a StatusPort?
And shouldn't it be called StatePort instead of StatusPort?

I think that's a misunderstanding. I'm talking about these StatusPorts or BroadcastPorts.

mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 28, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 3, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 3, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice linked a pull request Feb 3, 2022 that will close this issue
21 tasks
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
… and clarify what a Transaction is

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 4, 2022
…d remove wrong description of memory order

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 5, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 5, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice changed the title Design and implement new StatusPort Design new StatusPort Feb 12, 2022
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 12, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 12, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 12, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 12, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 12, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 12, 2022
…ood idea

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice
Copy link
Contributor Author

Not needed anymore. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants