Iox #841 upgrade gtest gmock to v1.10

[elBoberido]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

This PR updates GTest/GMock to v1.10 and removes some workarounds caused by v1.8.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Upgrade GTest/GMock to v1.10 #841

[codecov]

Codecov Report

Merging #1006 (d46593d) into master (a41fd66) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   77.69%   77.64%   -0.05%     
==========================================
  Files         338      338              
  Lines       12397    12397              
  Branches     1841     1841              
==========================================
- Hits         9632     9626       -6     
- Misses       2137     2143       +6     
  Partials      628      628              

Flag	Coverage Δ
unittests	76.57% <ø> (-0.04%)	⬇️
unittests_timing	30.03% <ø> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...x_posh/include/iceoryx_posh/iceoryx_posh_types.inl	70.96% <0.00%> (-9.68%)	⬇️
...lude/iceoryx_posh/internal/capro/capro_message.inl	82.92% <0.00%> (-7.32%)	⬇️
iceoryx_posh/source/popo/listener.cpp	81.25% <0.00%> (-2.50%)	⬇️
iceoryx_hoofs/source/concurrent/loffli.cpp	85.29% <0.00%> (+5.88%)	⬆️

[mossmaurice]

LGTM! I know it's tiresome, but please adapt the year in all files with new code 🙃

[elBoberido]

LGTM! I know it's tiresome, but please adapt the year in all files with new code upside_down_face

Sorry, but no. It was either code removal or mass search & replace. This is too trivial for a copyright update and we already handled it this way for other contributors.

[mossmaurice]

Sorry, but no. It was either code removal or mass search & replace. This is too trivial for a copyright update and we already handled it this way for other contributors.

Understood and I think you're right to keep the copyright update process as simple as possible! As IANL and our previous workflow was:

• Remove code -> Old copyright header
• Code was changed or added -> Adapt copyright header

Hence, I would appreciate if we could discuss this topic in the next developer meetup.

cc @budrus

[elBoberido]

@mossmaurice IANAL too but the last time I talked with one about this topic the answer was The change should be substantive before we claim Copyright protection and I got a thumbs up for my so we can use common sense for this question. I hereby claim to not be insane (was not tested, so it's only a claim) and a mass search and replace does not count for copyright update ;)

cc @budrus