Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #1010 unique id class #1011

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jan 6, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

This is needed for #894

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1011 (40bb509) into master (10a5506) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1011   +/-   ##
=======================================
  Coverage   77.59%   77.60%           
=======================================
  Files         334      335    +1     
  Lines       12370    12372    +2     
  Branches     1840     1840           
=======================================
+ Hits         9599     9601    +2     
  Misses       2141     2141           
  Partials      630      630           
Flag Coverage Δ
unittests 76.51% <100.00%> (+0.01%) ⬆️
unittests_timing 30.08% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/cxx/unique_id.cpp 100.00% <100.00%> (ø)
iceoryx_hoofs/source/posix_wrapper/timer.cpp 62.44% <0.00%> (-0.85%) ⬇️
iceoryx_hoofs/source/concurrent/loffli.cpp 91.17% <0.00%> (+5.88%) ⬆️

@elBoberido elBoberido force-pushed the iox-#1010-unique-id-class branch from 0c06284 to 4001778 Compare January 6, 2022 18:39
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elBoberido elBoberido merged commit c77a964 into eclipse-iceoryx:master Jan 11, 2022
@elBoberido elBoberido deleted the iox-#1010-unique-id-class branch January 11, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process scoped unique ID
3 participants