-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #1010 unique id class #1011
Merged
elBoberido
merged 4 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#1010-unique-id-class
Jan 11, 2022
Merged
Iox #1010 unique id class #1011
elBoberido
merged 4 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#1010-unique-id-class
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
requested review from
mossmaurice,
MatthiasKillat and
FerdinandSpitzschnueffler
January 6, 2022 14:10
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
=======================================
Coverage 77.59% 77.60%
=======================================
Files 334 335 +1
Lines 12370 12372 +2
Branches 1840 1840
=======================================
+ Hits 9599 9601 +2
Misses 2141 2141
Partials 630 630
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elBoberido
force-pushed
the
iox-#1010-unique-id-class
branch
from
January 6, 2022 18:39
0c06284
to
4001778
Compare
FerdinandSpitzschnueffler
previously approved these changes
Jan 10, 2022
mossmaurice
reviewed
Jan 10, 2022
mossmaurice
reviewed
Jan 10, 2022
elBoberido
force-pushed
the
iox-#1010-unique-id-class
branch
from
January 10, 2022 14:40
4001778
to
40bb509
Compare
mossmaurice
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FerdinandSpitzschnueffler
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
This is needed for #894
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References