Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1295 Fix request response example #1296

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Mar 17, 2022

Signed-off-by: Simon Hoinkis simon.hoinkis@apex.ai

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

  • Fix typo and broken link in example

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

…e example

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice added the example providing example for a specific feature label Mar 17, 2022
@mossmaurice mossmaurice self-assigned this Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1296 (4ac450a) into master (86deed9) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
- Coverage   78.96%   78.94%   -0.03%     
==========================================
  Files         371      371              
  Lines       14683    14683              
  Branches     2051     2051              
==========================================
- Hits        11594    11591       -3     
- Misses       2414     2416       +2     
- Partials      675      676       +1     
Flag Coverage Δ
unittests 78.16% <ø> (-0.04%) ⬇️
unittests_timing 15.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp 80.00% <0.00%> (-8.58%) ⬇️
...nternal/roudi/introspection/port_introspection.inl 82.11% <0.00%> (-0.73%) ⬇️
iceoryx_hoofs/source/posix_wrapper/timer.cpp 65.53% <0.00%> (+0.85%) ⬆️

@mossmaurice mossmaurice removed the request for review from dkroenke March 17, 2022 13:16
@mossmaurice mossmaurice merged commit eb51e64 into eclipse-iceoryx:master Mar 18, 2022
@mossmaurice mossmaurice deleted the iox-#1295-fix-request-response-example branch March 18, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example providing example for a specific feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release validation for v3.0
3 participants