Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of iox-#654, iox-#791, iox-#802 and iox-#808 to release branch #806

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented May 20, 2021

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

Backport of #804 to release_1.0 branch

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

…socket

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
@elBoberido elBoberido self-assigned this May 20, 2021
@elBoberido elBoberido added the bugfix Solves a bug label May 20, 2021
@elBoberido elBoberido changed the title [DO NOT MERGE] iox-#654 stop flooding output if there is an outdated socket [DO NOT MERGE YET] iox-#654 stop flooding output if there is an outdated socket May 20, 2021
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #806 (f51793a) into release_1.0 (4ba77c5) will increase coverage by 0.12%.
The diff coverage is 67.03%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release_1.0     #806      +/-   ##
===============================================
+ Coverage        73.87%   73.99%   +0.12%     
===============================================
  Files              318      319       +1     
  Lines            11077    11425     +348     
  Branches          1950     1972      +22     
===============================================
+ Hits              8183     8454     +271     
- Misses            2130     2195      +65     
- Partials           764      776      +12     
Flag Coverage Δ
unittests 72.80% <65.14%> (+0.08%) ⬆️
unittests_timing 30.65% <15.61%> (-1.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ude/iceoryx_binding_c/internal/cpp2c_publisher.hpp 100.00% <ø> (ø)
...de/iceoryx_binding_c/internal/cpp2c_subscriber.hpp 100.00% <ø> (ø)
iceoryx_binding_c/source/c_runtime.cpp 52.94% <0.00%> (-7.06%) ⬇️
...ceoryx_dds/include/iceoryx_dds/dds/data_writer.hpp 0.00% <ø> (ø)
...nclude/iceoryx_dds/internal/gateway/dds_to_iox.inl 44.18% <0.00%> (-7.17%) ⬇️
...nclude/iceoryx_dds/internal/gateway/iox_to_dds.inl 55.73% <0.00%> (-7.23%) ⬇️
...dds/source/iceoryx_dds/dds/cyclone_data_writer.cpp 0.00% <0.00%> (ø)
...ude/iceoryx_posh/internal/mepoo/memory_manager.hpp 100.00% <ø> (ø)
...clude/iceoryx_posh/internal/mepoo/shared_chunk.hpp 100.00% <ø> (ø)
...nternal/popo/building_blocks/chunk_distributor.hpp 100.00% <ø> (ø)
... and 150 more

@elBoberido
Copy link
Member Author

@dkroenke I think we need to port #802 to the release branch

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@dkroenke
Copy link
Member

@elBoberido

I think we need to port #802 to the release branch

I cherry-picked the commit.

@elBoberido
Copy link
Member Author

I guess I should also apply the fix for #791

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
@elBoberido elBoberido force-pushed the iox-#654-stop-flooding-output-if-there-is-an-outdated-socket-release-v1.0 branch from 92a8002 to a5ad11f Compare May 21, 2021 09:27
@elBoberido
Copy link
Member Author

@dkroenke shall I also backport the fix for #808 in this PR? I wanted to do a separate one but since the release branch is currently not building on some CI targets it might be better to do it here

@elBoberido elBoberido changed the title [DO NOT MERGE YET] iox-#654 stop flooding output if there is an outdated socket [DO NOT MERGE YET] backport of iox-#654, iox-#791 and iox-#802 to release branch May 21, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
@elBoberido elBoberido changed the title [DO NOT MERGE YET] backport of iox-#654, iox-#791 and iox-#802 to release branch [DO NOT MERGE YET] backport of iox-#654, iox-#791, iox-#802 and iox-#808 to release branch May 21, 2021
@elBoberido elBoberido linked an issue May 21, 2021 that may be closed by this pull request
@elfenpiff elfenpiff mentioned this pull request May 25, 2021
19 tasks
@elfenpiff
Copy link
Contributor

@elBoberido since you mentioned in issue #811 that the missing limits header is included in the correct cpptoml file via patch, could you please add the patch here. Or we do it with #812

@mossmaurice mossmaurice changed the title [DO NOT MERGE YET] backport of iox-#654, iox-#791, iox-#802 and iox-#808 to release branch backport of iox-#654, iox-#791, iox-#802 and iox-#808 to release branch May 25, 2021
@elBoberido elBoberido linked an issue May 25, 2021 that may be closed by this pull request
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
@elBoberido elBoberido requested a review from mossmaurice May 25, 2021 11:20
@elBoberido elBoberido merged commit f712571 into eclipse-iceoryx:release_1.0 May 25, 2021
@elBoberido elBoberido deleted the iox-#654-stop-flooding-output-if-there-is-an-outdated-socket-release-v1.0 branch May 25, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
4 participants