Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Ord so that ServiceName can be used in a BTreeMap #110

Closed
elfenpiff opened this issue Feb 7, 2024 · 0 comments · Fixed by #111
Closed

Implement Ord so that ServiceName can be used in a BTreeMap #110

elfenpiff opened this issue Feb 7, 2024 · 0 comments · Fixed by #111
Assignees
@elfenpiff
Labels
enhancement New feature or request

Comments

@elfenpiff
Copy link
Contributor

(Code) Example Of Cumbersome API

Currently, the ServiceName does not implement Ord and can therefore not be used in BTreeMap.

Improvement Suggestion

Implement Ord and PartialOrd for FixedByteString and then implement it in ServiceName via the derive macro.
@elfenpiff elfenpiff added the enhancement New feature or request label Feb 7, 2024
@elfenpiff elfenpiff self-assigned this Feb 7, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Feb 7, 2024
@elfenpiff
[eclipse-iceoryx#110] Implement Ord and PartialOrd for `ServiceNa…
610b51c 
…me` and `FixedByteString`
@elfenpiff elfenpiff mentioned this issue Feb 7, 2024
Merged
17 tasks
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Feb 7, 2024
@elfenpiff
[eclipse-iceoryx#110] Implement Ord and PartialOrd for `ServiceNa…
a11aab6 
…me` and `FixedByteString`
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Feb 7, 2024
@elfenpiff
[eclipse-iceoryx#110] Implement Ord and PartialOrd for `ServiceNa…
eec8168 
…me` and `FixedByteString`
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Feb 8, 2024
@elfenpiff
[eclipse-iceoryx#110] Use iterator based algorithm; add tests for par…
8972a62 
…tial ordering
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Feb 8, 2024
@elfenpiff
[eclipse-iceoryx#110] Implement Ord and PartialOrd for `ServiceNa…
e3b480e 
…me` and `FixedByteString`
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Feb 8, 2024
@elfenpiff
[eclipse-iceoryx#110] Use iterator based algorithm; add tests for par…
2895fbb 
…tial ordering
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Feb 8, 2024
@elfenpiff
[eclipse-iceoryx#110] Add ContainerId to ContainerHandle; simplify al…
2bc55bf 
…gorithm
elfenpiff added a commit that referenced this issue Feb 8, 2024
@elfenpiff
Merge pull request #111 from elfenpiff/iox2-110-implement-ord
2189bc6 
[#110] Implement `Ord` and `PartialOrd` for `ServiceName`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elfenpiff elfenpiff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#110] Implement Ord and PartialOrd for ServiceName elfenpiff/iceoryx2
1 participant
@elfenpiff