Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-defined service properties #231

Closed
elfenpiff opened this issue Jun 8, 2024 · 2 comments · Fixed by #232
Closed

user-defined service properties #231

elfenpiff opened this issue Jun 8, 2024 · 2 comments · Fixed by #232
Assignees

Comments

@elfenpiff
Copy link
Contributor

elfenpiff commented Jun 8, 2024

Brief feature description

Services may have properties that correspond to sensors or other constraints that cannot be represented in the context of iceoryx2. Therefore, the user needs the ability to set user-defined properties.

Detailed information

let service = zero_copy::Service::new(&service_name)
  // START: user-defined service properties
    .custom_property("CameraResolution", "1920x1080")
    .custom_property("Framerate", "60")
  // END: user-defined service properties
    .publish_subscribe::<TransmissionData>()
    .open_or_create()?;

The user-defined service properties can be read via the services static config:

let camera_resolution = service.static_config()
                               .custom_property("CameraResolution");
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 8, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 8, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 8, 2024
@elBoberido
Copy link
Member

Is the restriction to byte string literals necessary? Why not accept any valid UTF8 string?

@elfenpiff
Copy link
Contributor Author

@elBoberido just to test if you pay attention.

@elfenpiff elfenpiff self-assigned this Jun 9, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 9, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 9, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 10, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 10, 2024
… where the configured and not the actual static config is used; add test for property
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 10, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 10, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 10, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 10, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 11, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 11, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 11, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 11, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 13, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 13, 2024
elfenpiff added a commit that referenced this issue Jun 13, 2024
…properties

[#231] user defined service properties
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 13, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants