Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'win32call' needs to provide the last error #241

Closed
elBoberido opened this issue Jun 18, 2024 · 0 comments · Fixed by #242
Closed

'win32call' needs to provide the last error #241

elBoberido opened this issue Jun 18, 2024 · 0 comments · Fixed by #242
Assignees
Labels
bug Something isn't working

Comments

@elBoberido
Copy link
Member

Required information

Operating system:
Windows

Rust version:
all version but with the GNU toolchain, e.g. stable-gnu

Cargo version:
N/A

iceoryx2 version:
main

Observed result or behaviour:
At a few places win32call is instructed to ignore the error and later on GetLastError is called in order to check whether the ignored error occurred. It seems that with the MinGW toolchain the subsequent call to system_error_code_to_errno resets the error and GetLastError return 0, which makes the error handling futile.

Expected result or behaviour:
Some way to access the last error.

Conditions where it occurred / Performed steps:
Run the win32_udp_port_to_uds_name_set_and_get_works_with_multiple_instances test on latest-gnu on Windows and see the test fail.

@elBoberido elBoberido added the bug Something isn't working label Jun 18, 2024
@elBoberido elBoberido self-assigned this Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 18, 2024
elBoberido added a commit that referenced this issue Jun 19, 2024
…ingw

[#241] Fix 'win32call' for GNU toolchain on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant