Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API consistency while creating endpoints #244

Closed
elfenpiff opened this issue Jun 18, 2024 · 0 comments
Closed

API consistency while creating endpoints #244

elfenpiff opened this issue Jun 18, 2024 · 0 comments
Assignees
@elfenpiff
Labels
enhancement New feature or request

Comments

@elfenpiff
Copy link
Contributor

(Code) Example Of Cumbersome API

The upcoming Node will have a method called service_builder() to create a new service but the port factories methods are called publisher, subscriber etc.
To make it consistent they shall be renamed into publisher_builder(), subscriber_builder() ...
@elfenpiff elfenpiff added the enhancement New feature or request label Jun 18, 2024
@elfenpiff elfenpiff self-assigned this Jun 18, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 19, 2024
@elfenpiff
[eclipse-iceoryx#244] Add _builder suffix
ccb5872
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 19, 2024
@elfenpiff
[eclipse-iceoryx#244] Cleanup benchmark
8f0389d
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 19, 2024
@elfenpiff
[eclipse-iceoryx#244] Fix lifetime in Thread; use iceoryx2 thread wit…
cf7f997 
…h affinity and priority
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 19, 2024
@elfenpiff
[eclipse-iceoryx#244] Setup core affinities
710e54f
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 19, 2024
@elfenpiff
[eclipse-iceoryx#244] Add some async API remarks
4d2dd62
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 19, 2024
@elfenpiff
[eclipse-iceoryx#244] Adjust doc examples to new API
b147f5a
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 19, 2024
@elfenpiff
[eclipse-iceoryx#244] Adjust changelog
93bd9cd
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 19, 2024
@elfenpiff
[eclipse-iceoryx#244] Update readme
c84fa76
@elfenpiff elfenpiff mentioned this issue Jun 19, 2024
Merged
17 tasks
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Jun 19, 2024
@elfenpiff
[eclipse-iceoryx#244] Correct async mentions
faf7682
elfenpiff added a commit that referenced this issue Jun 19, 2024
@elfenpiff
Merge pull request #247 from elfenpiff/iox2-244-api-consistency
c81e751 
[#244] api consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elfenpiff elfenpiff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elfenpiff