[#129] fix missing connections #134

elfenpiff · 2024-02-23T09:42:12Z

Notes for Reviewer

The UsedChunkList exploits that the publisher/zero copy connection combination is using a pool allocator with equi-distant offset (buckets of same size). Therefore, we introduced number of samples and sample size.
We translate the memory addresses into indices (based on the above information) and set atomic bools to indicate if a sample is in use or not.

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Relates to #116
Closes #129 #130 #131 #132

codecov · 2024-02-23T09:45:31Z

Codecov Report

Attention: Patch coverage is 87.26287% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 77.61%. Comparing base (3d99f1d) to head (e35af3f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   77.40%   77.61%   +0.20%     
==========================================
  Files         179      180       +1     
  Lines       19668    19943     +275     
==========================================
+ Hits        15224    15478     +254     
- Misses       4444     4465      +21

Files	Coverage Δ
iceoryx2-bb/elementary/src/allocator.rs	`92.59% <ø> (+3.30%)`	⬆️
iceoryx2-bb/elementary/src/math.rs	`61.76% <100.00%> (+1.15%)`	⬆️
iceoryx2-bb/memory/src/bump_allocator.rs	`80.88% <100.00%> (-0.55%)`	⬇️
iceoryx2-bb/memory/src/heap_allocator.rs	`89.74% <100.00%> (-0.26%)`	⬇️
iceoryx2-bb/memory/src/pool_allocator.rs	`90.04% <100.00%> (-0.31%)`	⬇️
iceoryx2-bb/posix/src/file.rs	`66.50% <ø> (+0.15%)`	⬆️
iceoryx2-cal/src/dynamic_storage/process_local.rs	`95.51% <100.00%> (+0.32%)`	⬆️
iceoryx2-cal/src/shared_memory/mod.rs	`100.00% <ø> (ø)`
iceoryx2-cal/src/shared_memory/posix.rs	`88.14% <100.00%> (+0.15%)`	⬆️
iceoryx2-cal/src/shared_memory_directory/mod.rs	`90.36% <100.00%> (-0.06%)`	⬇️
... and 29 more

... and 5 files with indirect coverage changes

.cirrus.yml

…ring issue in container update

…onality

…-distant offsets

…tion

…ess for allocator

… aligned 1

…ections

…llocator check only performed in debug mode

…assert!

elBoberido

9 files to go. Looks good so far.

.cirrus.yml

iceoryx2-bb/memory/src/bump_allocator.rs

iceoryx2-bb/memory/tests/one_chunk_allocator_tests.rs

elBoberido · 2024-03-05T15:23:07Z

iceoryx2/src/port/notifier.rs

        };

        if let Err(e) = new_self.populate_listener_channels() {
            warn!(from new_self, "The new Notifier port is unable to connect to every Listener port, caused by {:?}.", e);
        }

+        std::sync::atomic::compiler_fence(Ordering::SeqCst);


Interesting. After reading the documentation, a few question marks remain. Especially since the example should be broken on a weakly ordered CPU

elBoberido

Only the mpmc::Container left but thats something for tomorrow

iceoryx2-cal/src/zero_copy_connection/posix_shared_memory.rs

iceoryx2/tests/service_publish_subscribe_tests.rs

iceoryx2/src/port/publisher.rs

iceoryx2-cal/src/zero_copy_connection/used_chunk_list.rs

iceoryx2-cal/tests/used_chunk_list_tests.rs

…e start into start_address for allocators; rename receive/retrieve channel into submission/completion channel; code cleanup

…kList

…abled

iceoryx2-bb/lock-free/src/mpmc/container.rs

…mory_size functions

…instead of acquiring it from the base address

elfenpiff force-pushed the iox2-129-fix-missing-connections branch from c073654 to 7d9ce08 Compare February 23, 2024 10:08

elfenpiff changed the title ~~Iox2 129 fix missing connections~~ [#129] fix missing connections Feb 25, 2024

elfenpiff requested a review from elBoberido February 26, 2024 23:41

elfenpiff force-pushed the iox2-129-fix-missing-connections branch 10 times, most recently from 850a2de to 280002c Compare March 3, 2024 23:48

elfenpiff commented Mar 4, 2024

View reviewed changes

.cirrus.yml Show resolved Hide resolved

elfenpiff added 15 commits March 5, 2024 15:28

[eclipse-iceoryx#129] Remove add with handle from container; fix orde…

3cde266

…ring issue in container update

[eclipse-iceoryx#129] Convert further tests to stripped API

33c2e7d

[eclipse-iceoryx#129] Add test concurrent test cases to pub/sub

d74d0bd

[eclipse-iceoryx#129] Fix problem where port handle was added to early

c25df45

[eclipse-iceoryx#129] Use copy_nonoverlapping instead of copy

ceebc3a

[eclipse-iceoryx#129] Use u64 as active index signal

d6fd33a

[eclipse-iceoryx#129] Fix container race between add and update

9876b0f

[eclipse-iceoryx#129] Fix bug in test

6cc4952

[eclipse-iceoryx#129] Introduce UsedChunkList

d81369a

[eclipse-iceoryx#129] Integrate used chunk list and add remove functi…

238b68f

…onality

[eclipse-iceoryx#129] Refactor UsedChunkList so that it requires equi…

a8e523b

…-distant offsets

[eclipse-iceoryx#129] Integrate used chunk list into zero copy connec…

685f11e

…tion

[eclipse-iceoryx#129] Integrate used chunk list into publisher

cd71098

[eclipse-iceoryx#129] Add single threaded connection tests

0e36d4e

[eclipse-iceoryx#129] Connection are cleaned up correctly

4223d18

elfenpiff added 10 commits March 5, 2024 15:28

[eclipse-iceoryx#129] Add method to acquire actual payload start addr…

2a9d27c

…ess for allocator

[eclipse-iceoryx#129] ShmAllocator payload starts always at zero when…

883049c

… aligned 1

[eclipse-iceoryx#129] Fix subscriber does not detect publisher reconn…

d74d54b

…ections

[eclipse-iceoryx#129] Fix clippy warnings, add release doc

535024a

[eclipse-iceoryx#129] Fix unique shm name id in mac os

75c0357

[eclipse-iceoryx#129] Add additional tests

40da244

[eclipse-iceoryx#129] Remove deallocation failure codes; ptr inside a…

bc71b94

…llocator check only performed in debug mode

[eclipse-iceoryx#129] Convert expensive API misuse checks into debug_…

d651564

…assert!

[eclipse-iceoryx#129] Adjust cirrus CI config

b8c9fa6

[eclipse-iceoryx#129] Deactivate FreeBSD temporarily

35b97b7

elfenpiff force-pushed the iox2-129-fix-missing-connections branch from 3a38661 to be5af47 Compare March 5, 2024 14:29

[eclipse-iceoryx#129] Enable FreeBSD

be5af47

elBoberido reviewed Mar 5, 2024

View reviewed changes

elfenpiff added 2 commits March 6, 2024 09:22

[eclipse-iceoryx#129] Use only_if to disable entries in cirrus; renam…

5ce7401

…e start into start_address for allocators; rename receive/retrieve channel into submission/completion channel; code cleanup

[eclipse-iceoryx#129] Use callback approach when cleaning up UsedChun…

5302e91

…kList

elfenpiff requested a review from elBoberido March 6, 2024 08:57

elfenpiff added 2 commits March 6, 2024 14:14

[eclipse-iceoryx#129] Run debug_assertion tests only when they are en…

ca5b1f0

…abled

[eclipse-iceoryx#129] Fix ambiguity in tests

cc5fca6

elBoberido reviewed Mar 6, 2024

View reviewed changes

iceoryx2-bb/lock-free/src/mpmc/container.rs Outdated Show resolved Hide resolved

[eclipse-iceoryx#129] Introduce unaligned_mem_size; simplify const_me…

b787bf5

…mory_size functions

elfenpiff requested a review from elBoberido March 6, 2024 22:44

[eclipse-iceoryx#129] Store SharedMemoryManagent in separate pointer …

e35af3f

…instead of acquiring it from the base address

elfenpiff force-pushed the iox2-129-fix-missing-connections branch from 5b9d0cf to e35af3f Compare March 6, 2024 22:50

elBoberido approved these changes Mar 6, 2024

View reviewed changes

elfenpiff merged commit 5c01563 into eclipse-iceoryx:main Mar 6, 2024
17 of 20 checks passed

elfenpiff deleted the iox2-129-fix-missing-connections branch March 6, 2024 23:33

elfenpiff mentioned this pull request Mar 7, 2024

[#11] Activate flaky windows test #150

Merged

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#129] fix missing connections #134

[#129] fix missing connections #134

elfenpiff commented Feb 23, 2024 •

edited by elBoberido

Loading

codecov bot commented Feb 23, 2024 •

edited

Loading

elBoberido left a comment

elBoberido Mar 5, 2024

elBoberido left a comment

[#129] fix missing connections #134

[#129] fix missing connections #134

Conversation

elfenpiff commented Feb 23, 2024 • edited by elBoberido Loading

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

codecov bot commented Feb 23, 2024 • edited Loading

Codecov Report

elBoberido left a comment

Choose a reason for hiding this comment

elBoberido Mar 5, 2024

Choose a reason for hiding this comment

elBoberido left a comment

Choose a reason for hiding this comment

elfenpiff commented Feb 23, 2024 •

edited by elBoberido

Loading

codecov bot commented Feb 23, 2024 •

edited

Loading