Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#133] write drop tests #144

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Mar 7, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #133

@elfenpiff elfenpiff requested a review from elBoberido March 7, 2024 00:09
@elfenpiff elfenpiff self-assigned this Mar 7, 2024
@elfenpiff elfenpiff force-pushed the iox2-133-write-drop-tests branch from 002c6d7 to 9b0c561 Compare March 7, 2024 00:10
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 77.80%. Comparing base (e35af3f) to head (13ea2ef).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   77.61%   77.80%   +0.19%     
==========================================
  Files         180      180              
  Lines       19943    19970      +27     
==========================================
+ Hits        15478    15537      +59     
+ Misses       4465     4433      -32     
Files Coverage Δ
iceoryx2-cal/src/shm_allocator/mod.rs 100.00% <ø> (ø)
iceoryx2/src/port/publisher.rs 83.33% <100.00%> (+0.39%) ⬆️
iceoryx2/src/service/builder/mod.rs 84.07% <100.00%> (+2.54%) ⬆️
iceoryx2/src/sample.rs 68.00% <85.71%> (+8.90%) ⬆️
iceoryx2/src/port/listener.rs 58.42% <25.00%> (-1.58%) ⬇️
iceoryx2/src/port/notifier.rs 80.13% <25.00%> (-1.56%) ⬇️
iceoryx2/src/port/subscriber.rs 84.14% <57.14%> (-1.39%) ⬇️
iceoryx2/src/service/builder/event.rs 63.18% <72.72%> (+0.23%) ⬆️
iceoryx2/src/service/builder/publish_subscribe.rs 81.40% <72.72%> (+1.15%) ⬆️

... and 8 files with indirect coverage changes

iceoryx2/tests/sample_mut_tests.rs Outdated Show resolved Hide resolved
iceoryx2/tests/sample_mut_tests.rs Outdated Show resolved Hide resolved
iceoryx2/tests/sample_mut_tests.rs Show resolved Hide resolved
iceoryx2/tests/sample_tests.rs Outdated Show resolved Hide resolved
iceoryx2/tests/service_event_tests.rs Outdated Show resolved Hide resolved
iceoryx2/tests/service_event_tests.rs Show resolved Hide resolved
iceoryx2/tests/service_event_tests.rs Show resolved Hide resolved
@elfenpiff elfenpiff requested a review from elBoberido March 11, 2024 08:57
…ests more explicit; add explanation to todos
@elfenpiff elfenpiff merged commit e4c339f into eclipse-iceoryx:main Mar 11, 2024
20 checks passed
@elfenpiff elfenpiff deleted the iox2-133-write-drop-tests branch March 11, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants