-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#133] write drop tests #144
Merged
elfenpiff
merged 8 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-133-write-drop-tests
Mar 11, 2024
Merged
[#133] write drop tests #144
elfenpiff
merged 8 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-133-write-drop-tests
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of acquiring it from the base address
…write drop tests; fix bug in sample releasing to wrong publisher
…les; add SampleMut tests
elfenpiff
force-pushed
the
iox2-133-write-drop-tests
branch
from
March 7, 2024 00:10
002c6d7
to
9b0c561
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 77.61% 77.80% +0.19%
==========================================
Files 180 180
Lines 19943 19970 +27
==========================================
+ Hits 15478 15537 +59
+ Misses 4465 4433 -32
|
elfenpiff
commented
Mar 7, 2024
elBoberido
reviewed
Mar 9, 2024
…ests more explicit; add explanation to todos
elBoberido
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #133