Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#175] example with complex data types #177

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Apr 9, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #

@elfenpiff elfenpiff requested a review from elBoberido April 9, 2024 07:51
@elfenpiff elfenpiff self-assigned this Apr 9, 2024
while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
// acquire and send out sample
let mut sample = publisher.loan()?;
sample.payload_mut().plain_old_data = counter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Food for thought. How about using this to get rid of some repititions

let payload = sample.payload_mut();
payload.plain_old_data = counter;
...

@elfenpiff elfenpiff merged commit 5560684 into eclipse-iceoryx:main Apr 9, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants