Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#200] 32 bit atomic64 #202

Merged
merged 7 commits into from
Apr 30, 2024

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Apr 22, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #200

@elfenpiff elfenpiff self-assigned this Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 99.51691% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.25%. Comparing base (3325ac9) to head (9ad018d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   78.99%   79.25%   +0.25%     
==========================================
  Files         182      183       +1     
  Lines       20213    20415     +202     
==========================================
+ Hits        15968    16179     +211     
+ Misses       4245     4236       -9     
Files Coverage Δ
iceoryx2-pal/concurrency-sync/src/iox_atomic.rs 100.00% <100.00%> (ø)
iceoryx2-pal/concurrency-sync/src/rwlock.rs 97.41% <80.00%> (-0.44%) ⬇️

... and 4 files with indirect coverage changes

@elfenpiff elfenpiff changed the title Iox2 200 32 bit atomic64 [#200] 32 bit atomic64 Apr 22, 2024
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not yet look at the tests

doc/release-notes/iceoryx2-unreleased.md Outdated Show resolved Hide resolved
iceoryx2-pal/concurrency-sync/src/ice_atomic.rs Outdated Show resolved Hide resolved
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea behind the compatibility tests is a bit unclear and I did not yet fully review them

@elfenpiff elfenpiff merged commit 82b1baf into eclipse-iceoryx:main Apr 30, 2024
45 of 47 checks passed
@elfenpiff elfenpiff deleted the iox2-200-32-bit-Atomic64 branch April 30, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants