Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#195] add sliced api #203

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Apr 22, 2024

Notes for Reviewer

This PR prepares the API for the new untyped API by introducing .typed::<T>() in the pub/sub builder which returns a typed builder.

In the upcoming sliced and untyped API a similar method will be introduced called .sliced::<T>() or .untyped() that will return a sliced- or untyped-builder.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #195

@elfenpiff elfenpiff self-assigned this Apr 22, 2024
@elfenpiff elfenpiff changed the title Iox2 195 add sliced api [#195] add sliced api Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 78.58%. Comparing base (1f15bc0) to head (9fdc62f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   78.55%   78.58%   +0.02%     
==========================================
  Files         181      181              
  Lines       19970    19984      +14     
==========================================
+ Hits        15688    15704      +16     
+ Misses       4282     4280       -2     
Files Coverage Δ
iceoryx2/src/config.rs 65.17% <ø> (ø)
iceoryx2/src/port/publisher.rs 81.86% <ø> (ø)
iceoryx2/src/port/subscriber.rs 85.79% <ø> (ø)
iceoryx2/src/port/update_connections.rs 0.00% <ø> (ø)
iceoryx2/src/sample.rs 70.83% <ø> (ø)
iceoryx2/src/sample_mut.rs 100.00% <ø> (ø)
...x2/src/service/dynamic_config/publish_subscribe.rs 94.44% <ø> (ø)
iceoryx2/src/service/header/publish_subscribe.rs 100.00% <ø> (ø)
iceoryx2/src/service/mod.rs 71.73% <ø> (ø)
...ryx2/src/service/port_factory/publish_subscribe.rs 89.28% <ø> (ø)
... and 6 more

... and 1 file with indirect coverage changes

@elfenpiff elfenpiff merged commit 0b85089 into eclipse-iceoryx:main Apr 23, 2024
47 checks passed
@elfenpiff elfenpiff deleted the iox2-195-add-sliced-api branch April 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants