Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#349] Add all remaining tests to bazel #482

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 19, 2024

Notes for Reviewer

The PR makes the remaining tests available to bazel.

Since bazel runs the tests in parallel, some of them needed to be adjusted for isolation.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #349

elBoberido and others added 30 commits October 19, 2024 04:14
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 18 lines in your changes missing coverage. Please review.

Project coverage is 79.14%. Comparing base (4dc37ec) to head (55e736a).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2/src/testing.rs 75.00% 8 Missing ⚠️
iceoryx2-bb/posix/src/testing.rs 44.44% 5 Missing ⚠️
iceoryx2-cal/src/testing.rs 87.50% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   78.92%   79.14%   +0.22%     
==========================================
  Files         198      200       +2     
  Lines       23627    23716      +89     
==========================================
+ Hits        18647    18771     +124     
+ Misses       4980     4945      -35     
Files with missing lines Coverage Δ
iceoryx2-bb/testing/src/lifetime_tracker.rs 88.00% <100.00%> (+2.28%) ⬆️
...l/src/communication_channel/posix_shared_memory.rs 90.64% <100.00%> (+7.11%) ⬆️
iceoryx2-cal/src/event/unix_datagram_socket.rs 87.66% <100.00%> (+1.05%) ⬆️
iceoryx2-cal/src/named_concept.rs 76.19% <ø> (ø)
iceoryx2-bb/posix/src/testing.rs 58.33% <44.44%> (-41.67%) ⬇️
iceoryx2-cal/src/testing.rs 87.50% <87.50%> (ø)
iceoryx2/src/testing.rs 75.00% <75.00%> (ø)

... and 14 files with indirect coverage changes

@elBoberido
Copy link
Member Author

@elfenpiff the nightly toolchain was updated and now the thread exit tests are failing on the unstable builds

@elBoberido elBoberido self-assigned this Oct 20, 2024
@elBoberido elBoberido merged commit 5f6a0dc into eclipse-iceoryx:main Oct 21, 2024
44 of 47 checks passed
@elBoberido elBoberido deleted the iox2-349-add-all-remaining-tests-to-bazel branch October 21, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants