Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.eclipse.jdt.internal.core.search.matching.MatchLocator.bindings may be wrong #3418

Closed
jukzi opened this issue Dec 9, 2024 · 0 comments
Closed

org.eclipse.jdt.internal.core.search.matching.MatchLocator.bindings may be wrong #3418

jukzi opened this issue Dec 9, 2024 · 0 comments
Assignees
@jukzi
Labels
bug Something isn't working

Comments

@jukzi
Copy link
Contributor

jukzi commented Dec 9, 2024

The type unsafe SimpleLookupTable may hide an error: char[] are added as keys, but it is tried to removed keys of type SearchPattern.

i will investigate.
@jukzi jukzi self-assigned this Dec 9, 2024
jukzi added a commit to jukzi/eclipse.jdt.core that referenced this issue Jan 6, 2025
@jukzi
fix search.matching.MatchLocator.bindings eclipse-jdt#3418
98e9dd3 
A map with keys char[] did only find keys by identity (but not by equal
characters as needed).

eclipse-jdt#3418

tested by RunJavaSearchTests
@jukzi jukzi mentioned this issue Jan 6, 2025
Merged
@jukzi jukzi added the bug Something isn't working label Jan 6, 2025
jukzi added a commit that referenced this issue Jan 7, 2025
@jukzi
fix search.matching.MatchLocator.bindings #3418
bb91fc9 
A map with keys char[] did only find keys by identity (but not by equal
characters as needed).

#3418

tested by RunJavaSearchTests
@jukzi jukzi closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukzi jukzi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jukzi