Apt.tests don't need org.eclipse.pde.core #1918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephan-herrmann Is "%ECLIPSE_HOME% resolving ( I ask as it's provided by pde.core (https://github.com/eclipse-pde/eclipse.pde/blob/69eb1b7bcf20d6316a6d164c28de7fdbe083877e/ui/org.eclipse.pde.core/plugin.xml#L28) and thus it creates one more build cycle between jdt and pde repositories. In theory smth similar is achievable by using core.variables plugin but considering this is only for testing purposes and ECLIPSE_HOME will continue to be evaluated just fine if pde.core is installed maybe some other test improvement (another classpath variable replacement?) would serve the same purpose. |
Wow, that's asking about events from 2005, which was slightly before my participation :) See It looks like the test just uses |
akurtakov
added a commit
to akurtakov/eclipse.jdt.core
that referenced
this pull request
Feb 9, 2024
Introduce new classpath variable in the test project to not rely on the pde.core one. Result of discussion in eclipse-jdt#1918
akurtakov
added a commit
to akurtakov/eclipse.jdt.core
that referenced
this pull request
Feb 9, 2024
Introduce new classpath variable in the test project to not rely on the pde.core one. Result of discussion in eclipse-jdt#1918
3 tasks
akurtakov
added a commit
to akurtakov/eclipse.jdt.core
that referenced
this pull request
Feb 9, 2024
Introduce new classpath variable in the test project to not rely on the pde.core one. Result of discussion in eclipse-jdt#1918
akurtakov
added a commit
to akurtakov/eclipse.jdt.core
that referenced
this pull request
Feb 9, 2024
Introduce new classpath variable in the test project to not rely on the pde.core one. Result of discussion in eclipse-jdt#1918
akurtakov
added a commit
that referenced
this pull request
Feb 9, 2024
Introduce new classpath variable in the test project to not rely on the pde.core one. Result of discussion in #1918
mickaelistria
pushed a commit
to mickaelistria/eclipse.jdt.core
that referenced
this pull request
Feb 16, 2024
Introduce new classpath variable in the test project to not rely on the pde.core one. Result of discussion in eclipse-jdt#1918
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
Introduce new classpath variable in the test project to not rely on the pde.core one. Result of discussion in eclipse-jdt#1918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Remove unneded dependency of o.e.jdat.apt.tests. Uncovered while working on eclipse-pde/eclipse.pde#1060
How to test
Verification builds completes without failing tests in the bundle.
Author checklist