Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECJ fails: Problem detected during type inference: Unknown error at invocation of getReadOnly(P) #2488

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

stephan-herrmann
Copy link
Contributor

fix for #2413 considering this advice:

additionally

  • avoid incrementing captureId when capture is reused not created
  • account for nullability of downwardsProjection (ITB18)
  • follow-up cleaning of IC18.findRPrimeAndResultingBounds()
  • avoid some array<->list conversions

invocation of getReadOnly(P)

fix for eclipse-jdt#2413 considering advice
* by Maurizio Cimadamore: inspect all pairs of matching supertypes
* by Dan Smith super type should use capture then upwards projection

additionally
+ avoid incrementing captureId when capture is reused not created
+ account for nullability of downwardsProjection (ITB18)
+ follow-up cleaning of IC18.findRPrimeAndResultingBounds()
+ avoid some array<->list conversions
@stephan-herrmann stephan-herrmann modified the milestones: MilestoneNxt, 4.33 May 30, 2024
@mpalat mpalat modified the milestones: 4.33, MilestoneNxt Jun 3, 2024
@stephan-herrmann stephan-herrmann merged commit cc0e66e into eclipse-jdt:master Jun 6, 2024
9 checks passed
@stephan-herrmann stephan-herrmann deleted the issue2413_3 branch June 6, 2024 10:16
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this pull request Jul 18, 2024
…nvocation of getReadOnly(P) (eclipse-jdt#2488)

fix for eclipse-jdt#2413 considering advice
* by Maurizio Cimadamore: inspect all pairs of matching supertypes
* by Dan Smith super type should use capture then upwards projection

additionally
+ avoid incrementing captureId when capture is reused not created
+ account for nullability of downwardsProjection (ITB18)
+ follow-up cleaning of IC18.findRPrimeAndResultingBounds()
+ avoid some array<->list conversions
gayanper pushed a commit to gayanper/eclipse.jdt.core that referenced this pull request Sep 7, 2024
…nvocation of getReadOnly(P) (eclipse-jdt#2488)

fix for eclipse-jdt#2413 considering advice
* by Maurizio Cimadamore: inspect all pairs of matching supertypes
* by Dan Smith super type should use capture then upwards projection

additionally
+ avoid incrementing captureId when capture is reused not created
+ account for nullability of downwardsProjection (ITB18)
+ follow-up cleaning of IC18.findRPrimeAndResultingBounds()
+ avoid some array<->list conversions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants