Merge master into BETA_JAVA24 #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egen.BranchLabel.USED (eclipse-jdt#3408) * Fixes eclipse-jdt#3407
…eclipse-jdt#3411) correction: + use of .prototype() fails with ParameterizedTypeBinding + instead use the binding id for detecting visited types polish: + clarify logical relationship between code blocks + avoid instantiating lots of lists Contributes to eclipse-jdt#3327 --------- Co-authored-by: Stephan Herrmann <stephan.herrmann@berlin.de>
Try to fix BuildpathTests.testChangeZIPArchive1() on linux. Small changes in file length and timeStamp could have produced hash collisions due to simple hash function. eclipse-jdt#3036
instead of streaming, because less source and it is a bit faster. For example MethodVerifyTest on windows: 65s->64s
* java.io.File.list() returns null if the file is not a directory, so File.isDirectory() is not needed. * use ConcurrentHashMap instead of Hashtable * avoid rawtypes ClasspathDirectory.directoryList(String) is a hotspot for example during NullTypeAnnotationTest
SuperTypeTest.test016(), SuperTypeTest.test017() failed when implementation of ReferenceBinding.hashCode() changed. The message was either "already defined by IChangeRulerColumn" or "already defined by IRevisionRulerColumn" depending on which Interface had the lower hashCode. Now using a LinkedHashMap to rely on the insertion order rather then the hashcode. relates to eclipse-jdt#3412
* avoids raw types * deletes custom ObjectCache ObjectCache implemented a HashMap using hashCode() but not equals(). Instead it used == identity. JDK offers a special Map for identity since 1.4, consistently using System.identityHashCode(). relates to eclipse-jdt#3412 Also solved follow up * LambdaExpression "Redundant specification of type arguments"
Signed-off-by: Rob Stryker <stryker@redhat.com>
…se-jdt#3438) without annotation support: + mark as shared, to change problem to MandatoryCloseNotShown + move this and sibling to irritant PotentiallyUnclosedCloseable with annotation support: + nothing changed, since we assume OWNED_BY_DEFAULT Fixes https://bugs.eclipse.org/561334
Signed-off-by: Rob Stryker <stryker@redhat.com> Cleanup Signed-off-by: Rob Stryker <stryker@redhat.com>
-proc:full is an explicit compiler argument to do full compilation and process annotations, which is the default compiler behavior. eclipse-jdt#3440
… for enum switches that are dispatched via enumSwitch indy(eclipse-jdt#3448) * Fixes eclipse-jdt#3447
Adjusting the tests to used the bundleContext to access org.eclipse.jdt.annotation, hence the initialization of the package admin can also be removed from the activator and therefore also the activator. Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Co-authored-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
…e-jdt#3445 Avoid nested directoryCache.computeIfAbsent to fix possible IllegalStateException with long upper case packages. fixes eclipse-jdt#3445
… analysis of syntax tree, to flag switch rule blocks that complete normally. (eclipse-jdt#3456) * Fixes eclipse-jdt#3455
…tch statement (eclipse-jdt#3410) * Fixes eclipse-jdt#3430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Author checklist