Remove needless TypeBinding hashCode() implementations #3412 #3477
+0
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukzi
force-pushed
the
TypeBindingWrapper_hashCodes
branch
from
4ada025 to
d73c10b
Compare
Since ArrayBinding does not override equals() any custom hashCode() implementation is likely to introduce hash collisions. Especially for same "leafComponentType" but different "dimensions" eclipse-jdt#3412
Since LocalTypeBinding does not override equals() any custom hashCode() implementation is likely to introduce hash collisions. Especially for same "enclosingType" but different "enclosingCase" eclipse-jdt#3412
Since WildcardBinding does not override equals() any custom hashCode() implementation is likely to introduce hash collisions. Especially for same "genericType" but different "bound" eclipse-jdt#3412
jukzi
force-pushed
the
TypeBindingWrapper_hashCodes
branch
from
d73c10b to
79091ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without overriding equals() any custom hashCode() implementation is likely to introduce hash collisions.
#3412