Add text selection support in code snippet #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheng Chen <sheche@microsoft.com>
fbricon
reviewed
Oct 21, 2019
| @@ -69,13 +69,13 @@ public String getId() { | |||
| public static final String SYSERR_CONTENT = "System.err.println($${0});"; | |||
| public static final String SYSTRACE_CONTENT = "System.out.println(\"${enclosing_type}.${enclosing_method}()\");"; | |||
| public static final String FOREACH_CONTENT = "for ($${1:${iterable_type}} $${2:${iterable_element}} : $${3:${iterable}}) {\n" + "\t$${0}\n" + "}"; | |||
There was a problem hiding this comment.
I didn't add it because the template in jdt.ui do not have the selection: https://github.com/eclipse/eclipse.jdt.ui/blob/master/org.eclipse.jdt.ui/templates/default-templates.xml#L37-L39, though I don't know why either 🤔.
Do you need me to add foreach also?
There was a problem hiding this comment.
Yes please, so it's more consistent
Signed-off-by: Sheng Chen <sheche@microsoft.com>
|
Thanks @jdneo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigate #1220
In jdt.ui,
for_array,while,do_whileandifhave theselectionplaceholder.Besides these snippets, I also add the
$TM_SELECTED_TEXTintoifnullandifnotnullSigned-off-by: Sheng Chen sheche@microsoft.com