Hide completions when signature help is enabled #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Signed-off-by: Frederik Claus <f.v.claus@googlemail.com>
Signed-off-by: Frederik Claus <f.v.claus@googlemail.com>
fvclaus
force-pushed
the
hide-completion-on-signature-help
branch
from
9209c3f to
4c20da2
Compare
|
@Eskibear can you please look at the code and decide if we can move forward with it or not? |
|
This doesn't seem to have an impact in vscode. I can see the filter text is simplified, but it still shows all completions, shows and inserts all parameters for an overloaded method. |
|
add to whitelist |
|
@fbricon When the filter text is used, vscode will hide completions once the |
|
For this to work, the signatureHelp needs to be active: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frederik Claus f.v.claus@googlemail.com
Implementation for redhat-developer/vscode-java#2063