-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce delegate command for java file paste #2981
Conversation
fe175da
to
cb863db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks pretty good. I'll have a closer look at the package logic later.
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
cb863db
to
6dc27b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good. Just some things to clean up.
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
6dc27b0
to
0ab10ab
Compare
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/PasteEventHandler.java
Outdated
Show resolved
Hide resolved
0ab10ab
to
c708293
Compare
It looks like you addressed everything @rgrunber mentioned and what I mentioned as well. Just a small comment: sometimes when getting reviews, its nice to leave the fixes as a separate commit so reviewers can go verify the specific changes made in response to the review. We can always squash later or even squash as part of the merge button here in github. But if you squash it first and force-push and essentially delete the previous version, it becomes harder to see what you changed upon review. But again, seems like you fixed everything that was mentioned. +1 from me (although I admit to not using the ASTParser much just yet.) |
@robstryker I use the compare commit link for that purpose |
Yeah, when I discovered the "force-pushed" was a link (eg. https://github.com/eclipse-jdtls/eclipse.jdt.ls/compare/0ab10ab5662c390309dc21882f1f92d02a769b52..c708293501fa5b8816675137516453450a93b833 ) it became easier to review though I agree that individual commits are more explicit. |
I get the following error on Windows :
|
Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
c708293
to
6a5056f
Compare
Update: I don't think this is coming from the language server. The code seems to be correct, so I think it's an incorrect value passed by the client-side code. |
Adds a delegate command that identifies whether or not some given clipboard text is a piece of java text and returns the correct path to the file to be created given relevant package declarations and/or type name.
Addresses redhat-developer/vscode-java#3323.