Sort the quick fix menu for imports in a order that makes sense #550
Conversation
There was a problem hiding this comment.
Rather than expecting a different, seemingly random, order like assertCodeActions(cu, e3, e1, e2, e4); in those tests assertions, I'd rather keep the assertions intact and rearrange the Expected instance declarations instead.
I understand it's more tedious to do now, but it will be more maintainable on the long term
| @@ -133,4 +136,19 @@ private static CompilationUnit getASTRoot(ICompilationUnit unit) { | |||
| return SharedASTProvider.getInstance().getAST(unit, new NullProgressMonitor()); | |||
| } | |||
|
|
|||
| class CUCorrectionProposalComparator implements Comparator<CUCorrectionProposal> { | |||
|
It doesn't work properly for InputStream for instance:
Compared to Eclipse: |
I can't reproduce the issue.
|
|
I'm definitely getting a different sort. And I rebuilt the server 3 times. I need to figure out why. FWIW, I'm using the latest vscode insiders build (1.21.0-insider 00f2d8ed7196606d31cc1759a171486d1cc00deb) |
|
The issue can be reproduced when using VS Code >= 1.20 |
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
@fbricon I have updated the PR. |
Fixes redhat-developer/vscode-java#424
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com