Add Support for specifying multiple tags in Zero Configuration mode

[rohanKanojia]

Description

This was originally suggested by @kameshsampath in chat. I'm just creating an issue about it for reference.

Right now if user wants to provide multiple tags on container image during build/push goals. He has to provide full image configuration like this:

            <plugin>
                <groupId>org.eclipse.jkube</groupId>
                <artifactId>kubernetes-maven-plugin</artifactId>
                <version>${jkube.version}</version>
                <configuration>
                  <images>
                    <image>
                      <name>${docker.user}/random-generator:${project.version}</name>
                      <build>
                        <from>quay.io/jkube/jkube-java-binary-s2i:0.0.10</from>
                        <assembly>
                        </assembly>
                        <tags>
                          <tag>${project.version}</tag>
                          <tag>latest</tag>
                        </tags>
                      </build>
                    </image>
                  </images>
                </configuration>
            </plugin>

It would be nice if we could support specifying multiple tags in zero-configuration mode via specifying some property.

I think we can implement this via adding a configuration option in BaseGenerator about comma-separated tags string:

https://github.com/eclipse/jkube/blob/bdfb00e1b02a7cbd84723ccf24a7413f940b4ebd/jkube-kit/generator/api/src/main/java/org/eclipse/jkube/generator/api/support/BaseGenerator.java#L59-L64

this configuration can be parsed later and tags can be added to BuildConfiguration builder, like latest tag is added for -SNAPSHOT versions here:

https://github.com/eclipse/jkube/blob/bdfb00e1b02a7cbd84723ccf24a7413f940b4ebd/jkube-kit/generator/api/src/main/java/org/eclipse/jkube/generator/api/support/BaseGenerator.java#L224

If we do this user would be able to specify multiple tags by just specifying generator config as property:

<jkube.generator.spring-boot.tags>tag1,tag2</jkube.generator.spring-boot.tags>

Info

• Eclipse JKube version : 1.5.1
• Maven version (mvn -v) :

Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: /opt/apache-maven
Java version: 11.0.11, vendor: Oracle Corporation, runtime: /usr/java/jdk-11.0.11
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.7-200.fc35.x86_64", arch: "amd64", family: "unix"

• Kubernetes / Red Hat OpenShift setup and version : N/A

• If it's a bug, how to reproduce : N/A

• If it's a feature request, what is your use case : Allow specifying multiple tags on opinionated images

• Sample Reproducer Project : N/A

[kameshsampath]

thanks @rohanKanojia @manusa for adding this :)

[manusa]

thanks @rohanKanojia @manusa for adding this :)

Nice to read you :)

I'm not sure if you're still using JKube, but Your feedback is very good, and you know we really appreciate it.
If you think of any other missing features or enhancements, please don't hesitate to reach out to us ;)

[kameshsampath]

sure thing! thanks for the trust 🙂

…

________________________________ From: Marc Nuri ***@***.***> Sent: Saturday, May 7, 2022 12:17 PM To: eclipse/jkube ***@***.***> Cc: Kamesh Sampath ***@***.***>; Mention ***@***.***> Subject: Re: [eclipse/jkube] Add Support for specifying multiple tags in Zero Configuration mode (Issue #1188) thanks @rohanKanojia<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2FrohanKanojia&data=05%7C01%7C%7Ca2bdadcd7c9f41340bb008da2ff5705e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637875028446180006%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1zqb96aco42WyZsKRTjcPF%2B5wk3j1Xi5gqI4Fgh%2BY00%3D&reserved=0> @manusa<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fmanusa&data=05%7C01%7C%7Ca2bdadcd7c9f41340bb008da2ff5705e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637875028446180006%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tX8v76liKM0muwRcWJF4cHLDhuauxX%2FS1VEvEPBPbVM%3D&reserved=0> for adding this :) Nice to read you :) I'm not sure if you're still using JKube, but Your feedback is very good, and you know we really appreciate it. If you think of any other missing features or enhancements, please don't hesitate to reach out to us ;) — Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Feclipse%2Fjkube%2Fissues%2F1188%23issuecomment-1120148206&data=05%7C01%7C%7Ca2bdadcd7c9f41340bb008da2ff5705e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637875028446180006%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BNF5BSuiTTWZroilVODAR5TOYitPc6fgQFujnsGK0xs%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fnotifications%2Funsubscribe-auth%2FAAHHMIMSW57ZTTG32TEZFJDVIYGXVANCNFSM5KWLMIGQ&data=05%7C01%7C%7Ca2bdadcd7c9f41340bb008da2ff5705e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637875028446180006%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5%2F9cBTfbk%2FJKWWMh5mdzQe6oM6Inucn%2FJcSeO3PXNdo%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>