Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicronautHealthCheckEnricher should also consider Micronaut Gradle Plugin in isApplicable #1634

Closed
2 tasks done
rohanKanojia opened this issue Jun 27, 2022 · 1 comment · Fixed by #1645
Closed
2 tasks done
Assignees
Labels
bug Something isn't working component/gradle-plugin Related to the Gradle Plugins
Milestone

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Jun 27, 2022

Component

JKube Kit

Task description

Description

MicronautHealthCheckEnricher has isApplicable method to check whether we should apply this enricher or not based on project dependencies:

https://github.com/eclipse/jkube/blob/61345823be63c73cf334649e33e9c5146f9d5f7a/jkube-kit/jkube-kit-micronaut/src/main/java/org/eclipse/jkube/micronaut/enricher/MicronautHealthCheckEnricher.java#L75-L79

It is not considering Micronaut Gradle Plugin. We should refactor this to use MicronautUtils.hasMicronautPlugin method which considers both cases:

-    if (!getContext().hasPlugin("io.micronaut.build", "micronaut-maven-plugin")) {
+    if (!hasMicronautPlugin(getContext().getProject())) {

Expected Behavior

Acceptance Criteria

  • Refactor isApplicable method to consider Micronaut Gradle Plugin
  • Port Micronaut health check documentation to gradle
@Prathamkrishna
Copy link
Contributor

hey rohan, I'll like to pick this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/gradle-plugin Related to the Gradle Plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants