Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusHealthCheckEnricher: default health path value is outdated in Quarkus 2.0.0.Final #758

Closed
rohanKanojia opened this issue Jul 2, 2021 · 1 comment · Fixed by #770
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rohanKanojia
Copy link
Member

Description

I was trying out @kameshsampath 's sample when I observed this, somehow pods were not coming in Ready state due to probe conditions not getting fulfilled. According to Quarkus docs[0], liveness healthchecks paths are

    /q/health/live - The application is up and running.
    /q/health/ready - The application is ready to serve requests.
    /q/health - Accumulating all health check procedures in the application.

However, when running mvn k8s:resource liveness/readiness probes are generated with this path:

        livenessProbe:
          failureThreshold: 3
          httpGet:
            path: /health/live
            port: 8080
            scheme: HTTP
          initialDelaySeconds: 10
          successThreshold: 1

        readinessProbe:
          failureThreshold: 3
          httpGet:
            path: /health/ready
            port: 8080
            scheme: HTTP
          initialDelaySeconds: 

Looks like behavior in quarkus has changed and /health/live, /health/ready URLs are no longer supported. I tested with another sample with Quarkus v1.13.7.Final and these were my observations:

v1.13.7.Final

jkube-quarkus-ingress : $ curl -si localhost:8080/health/ready
HTTP/1.1 301 Moved Permanently
location: /q/health/ready
content-length: 0

jkube-quarkus-ingress : $ curl -si localhost:8080/q/health/ready
HTTP/1.1 200 OK
content-type: application/json; charset=UTF-8
content-length: 46
{
    "status": "UP",
    "checks": [
    ]
}

v2.0.0.Final:

istio-multi-rev-demo : $ curl -si localhost:8080/health/ready
HTTP/1.1 404 Not Found
Content-Length: 0
Content-Type: application/json

istio-multi-rev-demo : $ curl -si localhost:8080/q/health/ready
HTTP/1.1 200 OK
content-type: application/json; charset=UTF-8
content-length: 46


{
    "status": "UP",
    "checks": [
    ]
}

[0] https://quarkus.io/guides/smallrye-health

Info

  • Eclipse JKube version : v1.3.0
  • Maven version (mvn -v) :
Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
Maven home: /opt/apache-maven
Java version: 11.0.11, vendor: Oracle Corporation, runtime: /usr/java/jdk-11.0.11
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.12.9-300.fc34.x86_64", arch: "amd64", family: "unix"
@rohanKanojia rohanKanojia changed the title QuarkusHealthCheckEnricher: default health path value is wrong. QuarkusHealthCheckEnricher: default health path value is outdated in Quarkus 2.0.0.Final Jul 2, 2021
@manusa manusa added the bug Something isn't working label Jul 2, 2021
@manusa manusa added this to the 1.4.0 milestone Jul 7, 2021
@rohanKanojia rohanKanojia self-assigned this Jul 8, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 8, 2021
… outdated

Update default value of health path to `/q/health`

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 9, 2021
… outdated

QuarkusHealthCheckEnricher now reads quarkus properties related to
rootPath, nonApplicationRootPath and health checks in order to
evaluate health check endpoints for Quarkus versions  greater than
1.11

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 9, 2021
… outdated

QuarkusHealthCheckEnricher now reads quarkus properties related to
rootPath, nonApplicationRootPath and health checks in order to
evaluate health check endpoints for Quarkus versions  greater than
1.11

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 12, 2021
… outdated

QuarkusHealthCheckEnricher now reads quarkus properties related to
rootPath, nonApplicationRootPath and health checks in order to
evaluate health check endpoints for Quarkus versions  greater than
1.11

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 13, 2021
… outdated

QuarkusHealthCheckEnricher now reads quarkus properties related to
rootPath, nonApplicationRootPath and health checks in order to
evaluate health check endpoints for Quarkus versions  greater than
1.11

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 13, 2021
… outdated

QuarkusHealthCheckEnricher now reads quarkus properties related to
rootPath, nonApplicationRootPath and health checks in order to
evaluate health check endpoints for Quarkus versions  greater than
1.11

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 13, 2021
… outdated

QuarkusHealthCheckEnricher now reads quarkus properties related to
rootPath, nonApplicationRootPath and health checks in order to
evaluate health check endpoints for Quarkus versions  greater than
1.11

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Jul 20, 2021
QuarkusHealthCheckEnricher now reads quarkus properties related to
rootPath, nonApplicationRootPath and health checks in order to
evaluate health check endpoints for Quarkus versions  greater than
1.11

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants