Fix: #2239 Quarkus k8s:resource automatic port pick up from application.properties #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2291 (2023-07-21T13:19:46Z) ⚙️ JKube E2E Tests (5622606031)
|
Codecov Report
@@ Coverage Diff @@
## master #2291 +/- ##
============================================
+ Coverage 59.36% 59.43% +0.07%
+ Complexity 4586 4570 -16
============================================
Files 500 504 +4
Lines 21211 21023 -188
Branches 2830 2779 -51
============================================
- Hits 12591 12495 -96
+ Misses 7370 7318 -52
+ Partials 1250 1210 -40
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Ankit Singh <ankit2.singh@samsung.com>
|
Kudos, SonarCloud Quality Gate passed! |
asingh2295
changed the title
| if (StringUtils.isNotBlank(profilePort)) { | ||
| return profilePort; | ||
| } | ||
| } |
There was a problem hiding this comment.
Why have you removed this code from this method?
|
You should not modify existing tests unless you really need to do it. They are there to validate currently expected behavior. |
18 tasks
|
I'm closing this one, need some discussion before merging. #2287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
k8s:resource doesn't automatically pick up port from Quarkus application.properties
Fixes #2239
Type of change
test, version modification, documentation, etc.)
Checklist