Fix 3326 : k8s resource acknowledge the port in application.properties for Micronaut application #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plication.properties, fix eclipse-jkube#3326 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
…clipse-jkube#3326 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
…se-jkube#3326 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
Eclipse JKube CI ReportStarted new GH workflow run for #3366 (2024-10-13T04:08:07Z) ⚙️ JKube E2E Tests (11311214381)
|
…e-jkube#3326 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
arman-yekkehkhani
requested review from
manusa,
rohanKanojia and
sunix
as code owners
| .map(ImageConfiguration::getBuild).map(BuildConfiguration::getPorts) | ||
| .orElse(Collections.emptyList()).stream() | ||
| .findFirst().orElse(null); | ||
|
|
||
| if (port == null) { | ||
| port = extractPort(getMicronautConfiguration(getContext().getProject()), null); |
There was a problem hiding this comment.
Do you think we can move this to orElse method of the above statement?
There was a problem hiding this comment.
Thanks! applied the changes.
| } | ||
| java { | ||
| sourceCompatibility = JavaVersion.toVersion("17") | ||
| targetCompatibility = JavaVersion.toVersion("17") |
There was a problem hiding this comment.
I think you've added this because of Micronaut 4 JDK 17 baseline requirement. This will fail on JDK 11 . Not sure whether we should move this test to micronaut 3
There was a problem hiding this comment.
Should we roll back to Micronaut 3 for the time being? Is there any hard limit on the JDK version for IT?
There was a problem hiding this comment.
I'll check with Marc about this and get back to you.
There was a problem hiding this comment.
Let's keep this Java11 friendly so we can merge it.
There was a problem hiding this comment.
@arman-yekkehkhani : Could you please use micronaut 3 instead?
There was a problem hiding this comment.
@rohanKanojia @manusa Thanks! changed Micronaut 4 to 3.
| @@ -85,10 +85,11 @@ private Probe buildProbe(Integer initialDelaySeconds, Integer periodSeconds){ | |||
| return null; | |||
| } | |||
|
|
|||
| final String firstImagePort = getImages().stream().findFirst() | |||
| String port = getImages().stream().findFirst() | |||
There was a problem hiding this comment.
Could you please revert it to the previous name? I think it was more accurate than the renamed version.
Suggested change
| String port = getImages().stream().findFirst() | |
| final String firstImagePort = getImages().stream().findFirst() |
There was a problem hiding this comment.
@rohanKanojia Yeah, thanks. applied the changes.
…ipse-jkube#3326 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
| */ | ||
| plugins { | ||
| id("com.github.johnrengelman.shadow") version "7.1.0" | ||
| id("io.micronaut.application") version "3.0.2" |
There was a problem hiding this comment.
Could you please use the latest version of 3.x release that's compatible with JDK11 ?
There was a problem hiding this comment.
Sure. updated.
fix eclipse-jkube#3326 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
rohanKanojia
approved these changes
Sep 23, 2024
|
@arman-yekkehkhani : Could you please resolve minor conflicts? I think this is good to be merged. |
# Conflicts: # CHANGELOG.md
|
@rohanKanojia Sure! It should be fixed now. |
|
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3326
Type of change
test, version modification, documentation, etc.)
Checklist