Provide support for setting BuildConfig memory/CPU requests and limits #99

rohanKanojia · 2020-03-06T09:23:58Z

Ported PR fabric8io/fabric8-maven-plugin#1772

codecov · 2020-03-06T09:37:13Z

Codecov Report

Merging #99 into master will increase coverage by 0.51%.
The diff coverage is 52.22%.

@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
+ Coverage     24.60%   25.11%   +0.51%     
- Complexity     1476     1515      +39     
============================================
  Files           349      350       +1     
  Lines         19240    19322      +82     
  Branches       2889     2908      +19     
============================================
+ Hits           4734     4853     +119     
+ Misses        13973    13916      -57     
- Partials        533      553      +20

Impacted Files	Coverage Δ	Complexity Δ
...kube/kit/config/resource/OpenshiftBuildConfig.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...ipse/jkube/kit/config/resource/ResourceConfig.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...onfig/service/openshift/OpenshiftBuildService.java	`51.87% <56.25%> (-0.39%)`	`48.00 <5.00> (+5.00)`	⬇️
...eclipse/jkube/kit/config/service/BuildService.java	`70.37% <66.66%> (-0.47%)`	`0.00 <0.00> (ø)`
...clipse/jkube/kit/common/util/KubernetesHelper.java	`14.59% <86.20%> (+14.59%)`	`25.00 <14.00> (+25.00)`
...va/org/eclipse/jkube/kit/common/util/FileUtil.java	`30.15% <0.00%> (+9.52%)`	`16.00% <0.00%> (+5.00%)`
...java/org/eclipse/jkube/kit/common/util/IoUtil.java	`70.17% <0.00%> (+56.14%)`	`9.00% <0.00%> (+4.00%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b34640...f27b67c. Read the comment docs.

jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/KubernetesHelper.java

manusa · 2020-03-06T14:09:48Z

jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/KubernetesHelper.java

+     * @param log log object
+     * @return file if present or null
+     */
+    public static File getResourceFragmentFromSource(File resourceDirFinal, List<String> remotes, String resourceNameSuffix, KitLogger log) {


Please provide some Unit Test validating and documenting the logic

jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/KubernetesHelper.java

Ported PR fabric8io/fabric8-maven-plugin#1772

sonarqubecloud · 2020-03-26T12:49:48Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 1 Security Hotspot to review)
0 Code Smells

65.5% Coverage
0.0% Duplication

manusa reviewed Mar 6, 2020

View reviewed changes