Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service event loader overrides the service event address with the module configured address #2263

Closed
riccardomodanese opened this issue Dec 14, 2018 · 0 comments · Fixed by #2264
Assignees
Labels
Bug This is a bug or an unexpected behaviour. Fix it!

Comments

@riccardomodanese
Copy link
Contributor

Describe the bug
The current service event implementation allows to set a different address to each service (ServiceEventClientConfiguration), but the service event loader (ServiceEventModule) uses the module address (ServiceEventModuleConfiguration) to bind the listening/raising service to the correct address.
This bug doesn't allow to specify a different listening/raising address for the services contained in the same module.

To Reproduce
Just try to configure a service with a different address than that contained in the module configuration.

Expected behavior

Screenshots

Version of Kapua
ALL

Type of deployment
[X] Local Vagrant deployment
[X] Docker
[X] Openshift (in its variants)
[] Others

Main component affected
[X] Console (in case of console please report info on which browser you encountered the problem)
[X] REST API
[X] Message Broker
[ ] - Others

Additional context
Add any other context about the problem here.

@riccardomodanese riccardomodanese self-assigned this Dec 14, 2018
riccardomodanese added a commit that referenced this issue Dec 14, 2018
… module configured address - see #2263

Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
riccardomodanese added a commit that referenced this issue Dec 17, 2018
… module configured address - see #2263

Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Dec 17, 2018
riccardomodanese added a commit that referenced this issue Dec 18, 2018
… module configured address - see #2263

Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
riccardomodanese added a commit that referenced this issue Dec 18, 2018
… module configured address - see #2263

Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
riccardomodanese added a commit that referenced this issue Dec 18, 2018
… module configured address - see #2263

Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
Coduz pushed a commit that referenced this issue Dec 18, 2018
… module configured address - see #2263

Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants