Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with large names in edit and delete dialogs #1194

Conversation

ct-goranpalibrk
Copy link
Contributor

@ct-goranpalibrk ct-goranpalibrk commented Dec 13, 2017

Issues #1113 ,#1114, #1115, #1116, #1119, #1120, #1121, #1122

Signed-off-by: CT\pgoran goran.palibrk@comtrade.com

Signed-off-by: CT\pgoran <goran.palibrk@comtrade.com>
@ct-goranpalibrk ct-goranpalibrk changed the title Fix problems with large names in edit and delete dialogs #1113 ,#1114, #1115, #1116, #1119, #1120, 31121, #1122 Fix problems with large names in edit and delete dialogs #1113 ,#1114, #1115, #1116, #1119, #1120, #1121, #1122 Dec 13, 2017
@LeoNerdoG
Copy link
Contributor

@ct-goranpalibrk @lorthirk
I have verified, that this PR resolves all the issues listed.

@lorthirk lorthirk changed the title Fix problems with large names in edit and delete dialogs #1113 ,#1114, #1115, #1116, #1119, #1120, #1121, #1122 Fix problems with large names in edit and delete dialogs Dec 18, 2017
@codecov
Copy link

codecov bot commented Dec 18, 2017

Codecov Report

Merging #1194 into develop will increase coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1194      +/-   ##
=============================================
+ Coverage      54.45%   55.42%   +0.96%     
- Complexity      1054     1107      +53     
=============================================
  Files           1003     1003              
  Lines          24929    25041     +112     
  Branches        2097     2117      +20     
=============================================
+ Hits           13576    13879     +303     
+ Misses         10483    10288     -195     
- Partials         870      874       +4
Impacted Files Coverage Δ Complexity Δ
...ervice/certificate/xml/CertificateXmlRegistry.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...pse/kapua/commons/service/internal/ServiceDAO.java 58.99% <0%> (+0.71%) 0% <0%> (ø) ⬇️
...a/service/device/registry/internal/DeviceImpl.java 94% <0%> (+1%) 0% <0%> (ø) ⬇️
...pse/kapua/service/device/steps/SimulatorSteps.java 94.21% <0%> (+1.05%) 60% <0%> (ø) ⬇️
...org/eclipse/kapua/service/user/steps/TestUser.java 40.47% <0%> (+2.38%) 11% <0%> (+1%) ⬆️
...lipse/kapua/kura/simulator/MqttAsyncTransport.java 55.55% <0%> (+2.77%) 0% <0%> (ø) ⬇️
...tication/shiro/AuthenticationServiceShiroImpl.java 53.51% <0%> (+3.26%) 0% <0%> (ø) ⬇️
...in/java/org/eclipse/kapua/qa/utils/Suppressed.java 50% <0%> (+3.44%) 11% <0%> (+1%) ⬆️
...lator/kura/kapua/TranslatorLifeBirthKuraKapua.java 96.36% <0%> (+3.63%) 7% <0%> (+1%) ⬆️
...lipse/kapua/transport/mqtt/MqttClientCallback.java 69.56% <0%> (+4.34%) 0% <0%> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c33c2b...f352889. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants