Fix Message Export with queries having more than 10000 results #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 5, 2018 11:33
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
In order to achieve this without overcoming Elasticsearch limits of 10000 results, more queries with 10000 row limit are aggregated. Due to this new behavior, data exported in XLS and CSV files are always sorted by Timestamp ascending, no matter the current view sort setting. Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
lorthirk
force-pushed
the
fix-datastore_limit_backend
branch
from
1a4e544 to
e24298b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1566 +/- ##
=============================================
+ Coverage 53.61% 53.65% +0.04%
- Complexity 1454 1456 +2
=============================================
Files 1128 1128
Lines 26879 26879
Branches 2337 2337
=============================================
+ Hits 14411 14423 +12
+ Misses 11530 11520 -10
+ Partials 938 936 -2
Continue to review full report at Codecov.
|
Coduz
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR aims at fixing #1534, so that the
DataExportServletdoesn't crash anymore due to Elasticsearch result set limit to 10000 rows. However, in order to achieve this, we have to specify data sorting as Timestamp Ascendent, ignoring any other sort setting selected in the Data View.While I was there I also fixed a couple of issues in the Data View (default sorting was not visible, sort by device id was not working) and refactored a bit exception displayed from REST APIs.