Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query button is disabled during query operation #1716

Merged
merged 1 commit into from
May 21, 2018
Merged

Conversation

muros-ct
Copy link
Contributor

Issue was showing if Query button was pressed so fast that query operation
didn't finish before next was triggered. That confused paging toolbar.
Solution was to disable button during query operation, so that user is
not able to trigger too many queries.

This solves issue #1628

Signed-off-by: Uros Mesaric Kunst uros.mesaric-kunst@comtrade.com

Issue was showing if Query button was pressed so fast that query operation
didn't finish before next was triggered. That confused paging toolbar.
Solution was to disable button during query operation, so that user is
not able to trigger too many queries.

This solves issue #1628

Signed-off-by: Uros Mesaric Kunst <uros.mesaric-kunst@comtrade.com>
@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

Merging #1716 into develop will increase coverage by 0.85%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1716      +/-   ##
=============================================
+ Coverage      53.61%   54.46%   +0.85%     
- Complexity      1423     1461      +38     
=============================================
  Files           1129     1129              
  Lines          26589    26589              
  Branches        2244     2244              
=============================================
+ Hits           14255    14483     +228     
+ Misses         11399    11171     -228     
  Partials         935      935
Impacted Files Coverage Δ Complexity Δ
.../service/device/call/message/kura/KuraPayload.java 47.68% <0%> (+1.32%) 24% <0%> (ø) ⬇️
...ore/plugin/authentication/AuthenticationLogic.java 90.9% <0%> (+1.51%) 0% <0%> (ø) ⬇️
...in/java/org/eclipse/kapua/qa/utils/Suppressed.java 50% <0%> (+1.72%) 11% <0%> (ø) ⬇️
...egistry/event/internal/DeviceEventServiceImpl.java 97.67% <0%> (+2.32%) 0% <0%> (ø) ⬇️
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 75.48% <0%> (+4.19%) 0% <0%> (ø) ⬇️
...in/java/org/eclipse/kapua/qa/steps/BasicSteps.java 67.85% <0%> (+7.14%) 8% <0%> (+1%) ⬆️
...pua/broker/core/plugin/metric/SubscribeMetric.java 100% <0%> (+9.09%) 0% <0%> (ø) ⬇️
...plugin/authentication/UserAuthenticationLogic.java 73.39% <0%> (+9.17%) 0% <0%> (ø) ⬇️
...pse/kapua/service/tag/internal/TagServiceImpl.java 59.18% <0%> (+10.2%) 12% <0%> (+2%) ⬆️
...kapua/commons/model/query/KapuaListResultImpl.java 72.22% <0%> (+11.11%) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111453e...9c54ad8. Read the comment docs.

@LeoNerdoG
Copy link
Contributor

I have verified that this PR successfully resolves issue #1628. It can be merged when all tests complete.

@muros-ct muros-ct merged commit 9a4775a into develop May 21, 2018
@muros-ct muros-ct deleted the fix-issue1628 branch May 21, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants