Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include client certificates in KapuaConnectionContext #1950

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

elbert3
Copy link
Contributor

@elbert3 elbert3 commented Aug 28, 2018

Include the client certificates in the KapuaConnectionContext. This allows further processing/checking of the certificates in the Authenticator.

Related Issue
N/A

Description of the solution adopted
N/A

Screenshots
N/A

Any side note on the changes made
N/A

@elbert3 elbert3 changed the base branch from release-1.0.0-M7 to develop August 29, 2018 15:53
Signed-off-by: Elbert Evangelista <elbert.evangelista@eurotech.com>
@elbert3 elbert3 force-pushed the fix-includeClientCerts branch from 5e11925 to e16bf89 Compare August 30, 2018 23:07
@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #1950 into develop will decrease coverage by 9.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1950      +/-   ##
============================================
- Coverage      55.38%   46.3%   -9.08%     
+ Complexity      1743    1203     -540     
============================================
  Files           1133    1134       +1     
  Lines          26785   26699      -86     
  Branches        2264    2260       -4     
============================================
- Hits           14835   12364    -2471     
- Misses         10998   13504    +2506     
+ Partials         952     831     -121
Impacted Files Coverage Δ Complexity Δ
...pua/broker/core/plugin/KapuaConnectionContext.java 70.83% <0%> (-13.23%) 0 <0> (ø)
...r/core/plugin/KapuaDuplicateClientIdException.java 0% <0%> (-100%) 0% <0%> (ø)
...ns/configuration/KapuaConfigurationErrorCodes.java 0% <0%> (-100%) 0% <0%> (ø)
...g/eclipse/kapua/test/steps/AbstractKapuaSteps.java 0% <0%> (-100%) 0% <0%> (-2%)
...iguration/metatype/XmlConfigPropertiesAdapted.java 0% <0%> (-100%) 0% <0%> (ø)
...store/internal/ClientInfoRegistryServiceProxy.java 0% <0%> (-100%) 0% <0%> (-4%)
...apua/service/user/internal/UserListResultImpl.java 0% <0%> (-100%) 0% <0%> (ø)
...ntication/shiro/KapuaAuthenticationErrorCodes.java 0% <0%> (-100%) 0% <0%> (ø)
...apua/broker/core/plugin/KapuaBrokerErrorCodes.java 0% <0%> (-100%) 0% <0%> (ø)
.../account/internal/setting/KapuaAccountSetting.java 0% <0%> (-100%) 0% <0%> (ø)
... and 327 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fdb902...e16bf89. Read the comment docs.

@Coduz Coduz merged commit 17d13e8 into eclipse-kapua:develop Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants